From eca70d1562c7acbe9a48944817c9fca34d93b8b5 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Wed, 28 May 2014 20:15:59 -0400 Subject: [PATCH] Get rid of the temporary buffer in IniFile's Load function. std::getline is the string-based equivalent. --- Source/Core/Common/IniFile.cpp | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/Source/Core/Common/IniFile.cpp b/Source/Core/Common/IniFile.cpp index 0424e20014..642835ac90 100644 --- a/Source/Core/Common/IniFile.cpp +++ b/Source/Core/Common/IniFile.cpp @@ -328,9 +328,6 @@ void IniFile::SortSections() bool IniFile::Load(const std::string& filename, bool keep_current_data) { - // Maximum number of letters in a line - static const int MAX_BYTES = 1024*32; - if (!keep_current_data) sections.clear(); // first section consists of the comments before the first real section @@ -339,18 +336,15 @@ bool IniFile::Load(const std::string& filename, bool keep_current_data) std::ifstream in; OpenFStream(in, filename, std::ios::in); - if (in.fail()) return false; + if (in.fail()) + return false; Section* current_section = nullptr; while (!in.eof()) { - char templine[MAX_BYTES]; std::string line; - if (in.getline(templine, MAX_BYTES)) - { - line = templine; - } - else + + if (!std::getline(in, line)) { if (in.eof()) return true;