Tilka 
							
						 
					 
					
						
						
							
						
						7588f5e2da 
					 
					
						
						
							
							Merge pull request  #12395  from lioncash/test  
						
						... 
						
						
						
						VertexLoaderTest: Resolve -Wdangling-else warnings 
						
						
					 
					
						2023-12-12 20:40:49 +00:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						18032f19a5 
					 
					
						
						
							
							AchievementManager: Resolve -Wshadow warnings  
						
						... 
						
						
						
						Renames some variables to avoid shadowing warnings on gcc.
Also gets rid of a FilereaderState struct, since one is already defined
in the declaration of the AchievementManager class. 
						
						
					 
					
						2023-12-12 15:37:20 -05:00 
						 
				 
			
				
					
						
							
							
								Admiral H. Curtiss 
							
						 
					 
					
						
						
							
						
						c1957ac169 
					 
					
						
						
							
							JitCommon: Fix feature_flags truncation in index calculation.  
						
						
						
						
					 
					
						2023-12-12 21:16:29 +01:00 
						 
				 
			
				
					
						
							
							
								Tilka 
							
						 
					 
					
						
						
							
						
						c92e402454 
					 
					
						
						
							
							Merge pull request  #12398  from lioncash/parse  
						
						... 
						
						
						
						RiivolutionParser: Make use of std::span where applicable 
						
						
					 
					
						2023-12-12 20:07:44 +00:00 
						 
				 
			
				
					
						
							
							
								Tilka 
							
						 
					 
					
						
						
							
						
						198a53e7df 
					 
					
						
						
							
							Merge pull request  #12397  from lioncash/asset  
						
						... 
						
						
						
						CustomAssetLibrary: Remove unused GetAssetSize() function 
						
						
					 
					
						2023-12-12 20:02:44 +00:00 
						 
				 
			
				
					
						
							
							
								Tilka 
							
						 
					 
					
						
						
							
						
						87b44a2fb8 
					 
					
						
						
							
							Merge pull request  #12400  from lioncash/expparse  
						
						... 
						
						
						
						ExpressionParser: Get rid of some redundant copies 
						
						
					 
					
						2023-12-12 19:17:29 +00:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						ded2d55438 
					 
					
						
						
							
							ExpressionParser: Avoid some miscellaneous copies  
						
						... 
						
						
						
						Just some trivial copies that can be eliminated or turned into moves. 
						
						
					 
					
						2023-12-12 14:03:41 -05:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						a5bbeb721a 
					 
					
						
						
							
							ExpressionParser: Mark constructors explicit where applicable  
						
						... 
						
						
						
						Makes for consistency with the surrounding code. 
						
						
					 
					
						2023-12-12 14:00:27 -05:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						ea71a76ea9 
					 
					
						
						
							
							ExpressionParser: Pass control qualifiers by const reference  
						
						... 
						
						
						
						These aren't necessarily cheap to copy, since a control qualifier will
have around 3 std::strings inside of it, so passing by value can churn
allocations a little bit. 
						
						
					 
					
						2023-12-12 13:50:46 -05:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						9aea481e59 
					 
					
						
						
							
							ExpressionParser: Make use of std::erase_if  
						
						
						
						
					 
					
						2023-12-12 13:31:58 -05:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						196f8e5123 
					 
					
						
						
							
							MappingCommon: Make use of std::erase_if  
						
						
						
						
					 
					
						2023-12-12 13:31:18 -05:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						888a8692b4 
					 
					
						
						
							
							SysConf: Make use of std::erase_if  
						
						
						
						
					 
					
						2023-12-12 13:30:39 -05:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						01d15994fe 
					 
					
						
						
							
							PatchEngine: Make use of std::erase  
						
						
						
						
					 
					
						2023-12-12 13:30:08 -05:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						e69ac2d43e 
					 
					
						
						
							
							Socket: Make use of std::erase_if  
						
						
						
						
					 
					
						2023-12-12 13:29:33 -05:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						96eac73d11 
					 
					
						
						
							
							NetKDRequest: Make use of std::erase  
						
						
						
						
					 
					
						2023-12-12 13:27:54 -05:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						e7f7dde546 
					 
					
						
						
							
							Formats: Make use of std::erase_if  
						
						
						
						
					 
					
						2023-12-12 13:27:17 -05:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						df227aa03c 
					 
					
						
						
							
							I2CBus: Make use of std::erase_if  
						
						
						
						
					 
					
						2023-12-12 13:26:47 -05:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						ff0e7fbf08 
					 
					
						
						
							
							GeckoCodeConfig: Make use of std::erase_if  
						
						
						
						
					 
					
						2023-12-12 13:26:16 -05:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						84ae0c1c7e 
					 
					
						
						
							
							ActionReplay: Make use of std::erase_if  
						
						
						
						
					 
					
						2023-12-12 13:25:26 -05:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						50e4dc5dba 
					 
					
						
						
							
							Watches: Make use of std::erase_if  
						
						
						
						
					 
					
						2023-12-12 13:24:40 -05:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						b728e37086 
					 
					
						
						
							
							RiivolutionParser: Remove usages of global system accessor  
						
						... 
						
						
						
						We can retrieve the encompassing system instance through the
CPUThreadGuard instance instead. 
						
						
					 
					
						2023-12-12 12:48:40 -05:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						c2e39e0d68 
					 
					
						
						
							
							RiivolutionParser: Make use of std::span where applicable  
						
						... 
						
						
						
						The main interface for these only take in patches and iterate over them
in a contiguous sequence, so we can reasonably generify the interface. 
						
						
					 
					
						2023-12-12 12:38:43 -05:00 
						 
				 
			
				
					
						
							
							
								iwubcode 
							
						 
					 
					
						
						
							
						
						b69d336838 
					 
					
						
						
							
							VideoCommon: update shader asset to provide a variant default value  
						
						
						
						
					 
					
						2023-12-12 00:01:22 -06:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						4c7a4831cb 
					 
					
						
						
							
							CustomAssetLibrary: Remove unused GetAssetSize() function  
						
						... 
						
						
						
						There's a direct analogue of this function within
DirectFilesystemAssetLibrary that *is* used, however, so we can get rid
of this one. 
						
						
					 
					
						2023-12-11 22:00:52 -05:00 
						 
				 
			
				
					
						
							
							
								Admiral H. Curtiss 
							
						 
					 
					
						
						
							
						
						2c6bf2d224 
					 
					
						
						
							
							Merge pull request  #12394  from lioncash/compare  
						
						... 
						
						
						
						General: Resolve -Wsign-compare warnings 
						
						
					 
					
						2023-12-12 03:43:12 +01:00 
						 
				 
			
				
					
						
							
							
								Admiral H. Curtiss 
							
						 
					 
					
						
						
							
						
						9326186d2c 
					 
					
						
						
							
							Merge pull request  #12396  from lioncash/opeq  
						
						... 
						
						
						
						Core/SyncIdentifier: Default operator== 
						
						
					 
					
						2023-12-12 03:42:18 +01:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						e011c3b383 
					 
					
						
						
							
							Core/SyncIdentifier: Default operator==  
						
						... 
						
						
						
						Lets us remove a bunch of code and a dependency on the <tuple> header. 
						
						
					 
					
						2023-12-11 19:39:55 -05:00 
						 
				 
			
				
					
						
							
							
								Tilka 
							
						 
					 
					
						
						
							
						
						6699acf10c 
					 
					
						
						
							
							Merge pull request  #12386  from lioncash/setting  
						
						... 
						
						
						
						Common/SettingsHandler: Minor convenience changes 
						
						
					 
					
						2023-12-12 00:02:21 +00:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						4229d76ad6 
					 
					
						
						
							
							VertexLoaderTest: Resolve -Wdangling-else warnings  
						
						... 
						
						
						
						The ways the assertion macros expand end up generating -Wdangling-else
warnings. Trivial enough to fix by just bracing the if statements. 
						
						
					 
					
						2023-12-11 18:45:25 -05:00 
						 
				 
			
				
					
						
							
							
								Admiral H. Curtiss 
							
						 
					 
					
						
						
							
						
						f04d834e8f 
					 
					
						
						
							
							Merge pull request  #12393  from lioncash/tls  
						
						... 
						
						
						
						DolphinQT/Host: Remove unused TLS variable tls_is_host_thread 
						
						
					 
					
						2023-12-12 00:29:21 +01:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						0e51c0f8fc 
					 
					
						
						
							
							JitArm64_RegCache: Resolve -Wsign-compare warning  
						
						
						
						
					 
					
						2023-12-11 18:15:50 -05:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						4c3a5eb1c5 
					 
					
						
						
							
							JitArm64_SystemRegisters: Resolve -Wsign-compare warning  
						
						
						
						
					 
					
						2023-12-11 18:11:34 -05:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						017b9a0af7 
					 
					
						
						
							
							FloatUtilsTest: Resolve -Wsign-compare warning  
						
						
						
						
					 
					
						2023-12-11 18:08:52 -05:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						4bef3b93b4 
					 
					
						
						
							
							AndroidCommon: Resolve -Wsign-compare warning  
						
						
						
						
					 
					
						2023-12-11 18:06:40 -05:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						f97316a1e6 
					 
					
						
						
							
							TraversalClient: Resolve -Wsign-compare warning  
						
						
						
						
					 
					
						2023-12-11 18:01:29 -05:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						49f44c1334 
					 
					
						
						
							
							VertexManagerBase: Resolve -Wsign-compare warning  
						
						
						
						
					 
					
						2023-12-11 18:00:34 -05:00 
						 
				 
			
				
					
						
							
							
								Admiral H. Curtiss 
							
						 
					 
					
						
						
							
						
						b48af86148 
					 
					
						
						
							
							Merge pull request  #12390  from lioncash/string  
						
						... 
						
						
						
						GraphicsModListWidget: Add string specifier to By and Description fields 
						
						
					 
					
						2023-12-11 23:47:53 +01:00 
						 
				 
			
				
					
						
							
							
								Admiral H. Curtiss 
							
						 
					 
					
						
						
							
						
						4f02f526b8 
					 
					
						
						
							
							Merge pull request  #12392  from lioncash/decl  
						
						... 
						
						
						
						General: Resolve -Wmissing-declaration warnings 
						
						
					 
					
						2023-12-11 23:39:23 +01:00 
						 
				 
			
				
					
						
							
							
								Admiral H. Curtiss 
							
						 
					 
					
						
						
							
						
						54301d709a 
					 
					
						
						
							
							Merge pull request  #12389  from lioncash/cheeve  
						
						... 
						
						
						
						AchievementManager: Make GetInstance() and GetLock() return a reference 
						
						
					 
					
						2023-12-11 23:37:29 +01:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						f490b990f5 
					 
					
						
						
							
							DolphinQT/Host: Remove unimplemented prototypes  
						
						... 
						
						
						
						Remnants of prior existing code. 
						
						
					 
					
						2023-12-11 17:30:56 -05:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						d705c31d1a 
					 
					
						
						
							
							DolphinQT/Host: Remove unused TLS variable tls_is_host_thread  
						
						... 
						
						
						
						This is never accessed or read from. 
						
						
					 
					
						2023-12-11 17:27:57 -05:00 
						 
				 
			
				
					
						
							
							
								Admiral H. Curtiss 
							
						 
					 
					
						
						
							
						
						16ba56a34b 
					 
					
						
						
							
							Merge pull request  #12388  from lioncash/compare  
						
						... 
						
						
						
						GameFile: Default GameBanner operator== 
						
						
					 
					
						2023-12-11 23:25:27 +01:00 
						 
				 
			
				
					
						
							
							
								Tilka 
							
						 
					 
					
						
						
							
						
						c6a10b5740 
					 
					
						
						
							
							Merge pull request  #12391  from lioncash/reorder  
						
						... 
						
						
						
						General: Resolve -Wreorder warnings 
						
						
					 
					
						2023-12-11 22:09:48 +00:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						e8b4796273 
					 
					
						
						
							
							PostProcessing: Mark helper functions as static  
						
						... 
						
						
						
						These didn't have any prototypes and were generating
-Wmissing-declaration warnings. 
						
						
					 
					
						2023-12-11 17:07:59 -05:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						abb5cc3a3a 
					 
					
						
						
							
							ShaderAsset: Mark ParseShaderProperties() as static  
						
						... 
						
						
						
						This had no function prototype, so this can be internally linked.
Resolves a -Wmissing-declaration warning. 
						
						
					 
					
						2023-12-11 17:05:06 -05:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						b4b624b97b 
					 
					
						
						
							
							WC24PatchEngine: Mark LoadPatches() as static  
						
						... 
						
						
						
						Resolves a -Wmissing-declaration warning, since no prototype existed for
the function. 
						
						
					 
					
						2023-12-11 17:02:15 -05:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						2b2ee61e79 
					 
					
						
						
							
							CustomShaderCache: Resolve -Wreorder warnings  
						
						... 
						
						
						
						Lays out the initializer lists to be in the same order that
initialization would occur in. 
						
						
					 
					
						2023-12-11 16:59:03 -05:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						9472da788d 
					 
					
						
						
							
							ConfigFloatSlider: Resolve -Wreorder warnings  
						
						... 
						
						
						
						Orders the initializer list the way that the members would actually be
initialized in.
Resolves some -Wreorder warnings 
						
						
					 
					
						2023-12-11 16:15:48 -05:00 
						 
				 
			
				
					
						
							
							
								Admiral H. Curtiss 
							
						 
					 
					
						
						
							
						
						dd0ac7d53c 
					 
					
						
						
							
							Merge pull request  #12387  from lioncash/cache  
						
						... 
						
						
						
						GameFileCache: Pass std::function by reference rather than by value 
						
						
					 
					
						2023-12-11 21:46:59 +01:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						5d1514418e 
					 
					
						
						
							
							GraphicsModListWidget: Add string specifier to By and Description fields  
						
						... 
						
						
						
						Translators should always know where text is going to be appended and
have the ability to move things around to fit the language better. 
						
						
					 
					
						2023-12-11 15:43:41 -05:00