13643 Commits

Author	SHA1	Message	Date
JosJuice	84ac561e46	Merge pull request #12421 from lioncash/fwd ... WC24PatchEngine: Move IniFile header dependency into the cpp file	2023-12-14 21:21:59 +01:00
Lioncash	88431cfbca	WC24PatchEngine: Make GetNetworkPatch() take a std::string_view ... Makes it consistent with GetNetworkPatchByPayload()	2023-12-14 14:24:49 -05:00
Lioncash	fa70a8fd01	WC24PatchEngine: Make a few functions internally linked ... These are only used within this translation unit, so we can remove the IniFile dependency from the header.	2023-12-14 14:23:41 -05:00
Lioncash	14abdab314	SysConf: std::move fs pointer in constructor ... Just gets rid of a trivial atomic reference count increment and decrement. Not a super heavyweight thing, but it is essentially "free" to get rid of.	2023-12-14 14:01:17 -05:00
Tilka	df922afdbb	Merge pull request #12412 from lioncash/maybe ... DSPInterpreter: Mark IsProperlySignExtended() as [[maybe_unused]]	2023-12-13 15:52:32 +00:00
Tilka	52a144745d	Merge pull request #12408 from lioncash/enums ... General: Resolve -Wswitch warnings	2023-12-13 15:48:12 +00:00
LillyJadeKatrin	aa3e1e2324	Retroachievements - Fixed Login Checks ... Two fixes: verify that there's an API token before attempting to automatically log in, and don't attempt to hash a game and load it unless achievements are enabled and the player is logged in. This prevents multiple API requests that we already know will fail, one of which will display an unnecessary error message to the player.	2023-12-13 09:00:25 -05:00
Lioncash	ecd7fa4380	DSPInterpreter: Mark IsProperlySignExtended() as [[maybe_unused]] ... This function is used in debug asserts, so in release builds this will go unused and otherwise generate a warning	2023-12-12 21:02:15 -05:00
Lioncash	91f691296c	IOS/Crypto/Sha: Handle ShaCommandUnknown in IOCtlV ... Resolves a -Wswitch warning.	2023-12-12 17:42:36 -05:00
Lioncash	c14b3539c9	CPUThreadConfigCallback: Mark static ID as [[maybe_unused]] ... This isn't used, but is likely kept around so the one-timed execution of a magic static is taken advantage of.	2023-12-12 17:30:37 -05:00
Lioncash	79c84c98ed	WC24PatchEngine: Resolve -Wshadow warning ... While not captured, we're definitely shadowing the result variable outside the lambda.	2023-12-12 17:03:42 -05:00
Lioncash	81d5370141	HLE_OS: Resolve -Wshadow warnings ... We get a warning about shadowing the va_list type and just run-of-the-mill variable shadowing, which we can easily fix.	2023-12-12 17:01:32 -05:00
Tilka	6184ec655e	Merge pull request #12403 from lioncash/uninit ... PPCDebugInterface: Silence trivial -Wmaybe-uninitialized warning	2023-12-12 21:49:01 +00:00
Tilka	995eb779fa	Merge pull request #12402 from lioncash/shadow ... AchievementManager: Resolve -Wshadow warnings	2023-12-12 21:42:21 +00:00
Tilka	b4bfc4feba	Merge pull request #12401 from AdmiralCurtiss/feature-flag-fix ... JitCommon: Fix feature_flags truncation in index calculation.	2023-12-12 20:56:04 +00:00
Tilka	8cbb2c2e44	Merge pull request #12399 from lioncash/erasing ... General: Make use of std::erase_if/std::erase where applicable	2023-12-12 20:54:52 +00:00
Tilka	99959944eb	Merge pull request #12376 from lioncash/span2 ... VFFUtil: Use std::span with WriteToVFF	2023-12-12 20:50:17 +00:00
Lioncash	b0b1308160	PPCDebugInterface: Silence trivial -Wmaybe-uninitialized warning ... We can just initialize register_index, even if it gets overwritten later on via Common::FromChars.	2023-12-12 15:42:28 -05:00
Lioncash	18032f19a5	AchievementManager: Resolve -Wshadow warnings ... Renames some variables to avoid shadowing warnings on gcc. Also gets rid of a FilereaderState struct, since one is already defined in the declaration of the AchievementManager class.	2023-12-12 15:37:20 -05:00
Admiral H. Curtiss	c1957ac169	JitCommon: Fix feature_flags truncation in index calculation.	2023-12-12 21:16:29 +01:00
Lioncash	888a8692b4	SysConf: Make use of std::erase_if	2023-12-12 13:30:39 -05:00
Lioncash	01d15994fe	PatchEngine: Make use of std::erase	2023-12-12 13:30:08 -05:00
Lioncash	e69ac2d43e	Socket: Make use of std::erase_if	2023-12-12 13:29:33 -05:00
Lioncash	96eac73d11	NetKDRequest: Make use of std::erase	2023-12-12 13:27:54 -05:00
Lioncash	e7f7dde546	Formats: Make use of std::erase_if	2023-12-12 13:27:17 -05:00
Lioncash	df227aa03c	I2CBus: Make use of std::erase_if	2023-12-12 13:26:47 -05:00
Lioncash	ff0e7fbf08	GeckoCodeConfig: Make use of std::erase_if	2023-12-12 13:26:16 -05:00
Lioncash	84ae0c1c7e	ActionReplay: Make use of std::erase_if	2023-12-12 13:25:26 -05:00
Admiral H. Curtiss	2c6bf2d224	Merge pull request #12394 from lioncash/compare ... General: Resolve -Wsign-compare warnings	2023-12-12 03:43:12 +01:00
Lioncash	e011c3b383	Core/SyncIdentifier: Default operator== ... Lets us remove a bunch of code and a dependency on the <tuple> header.	2023-12-11 19:39:55 -05:00
Lioncash	0e51c0f8fc	JitArm64_RegCache: Resolve -Wsign-compare warning	2023-12-11 18:15:50 -05:00
Lioncash	4c3a5eb1c5	JitArm64_SystemRegisters: Resolve -Wsign-compare warning	2023-12-11 18:11:34 -05:00
Admiral H. Curtiss	4f02f526b8	Merge pull request #12392 from lioncash/decl ... General: Resolve -Wmissing-declaration warnings	2023-12-11 23:39:23 +01:00
Lioncash	b4b624b97b	WC24PatchEngine: Mark LoadPatches() as static ... Resolves a -Wmissing-declaration warning, since no prototype existed for the function.	2023-12-11 17:02:15 -05:00
Lioncash	d90537cc18	AchievementManager: Return by reference from GetLock() ... This makes the API a little nicer to use, since you don't need to do a mandatory dereference when passing the lock into any kind of scope guard.	2023-12-11 13:51:50 -05:00
Lioncash	e55f9ed102	AchievementManager: Make GetInstance() return a reference ... The internal static member will always have a valid lifetime. Makes this consistent with other instance based objects in our code.	2023-12-11 13:36:39 -05:00
Admiral H. Curtiss	694b3b4ea1	HW/CEXIIPL: Fix loading files at nonzero offset in LoadFileToIPL().	2023-12-11 02:22:06 +01:00
Mai	c2b642d0b7	Merge pull request #12381 from AdmiralCurtiss/re-enable-achievement-nag ... AchievementManager: Only nag user about disabled achievements when they were actually enabled before.	2023-12-10 20:16:24 -05:00
Mai	bdd28f1f26	Merge pull request #12378 from JosJuice/jitarm64-a-early-discard ... JitArm64: Add additional condition for lmw/stmw a discard	2023-12-10 20:15:57 -05:00
Admiral H. Curtiss	70cd0040a3	AchievementManager: Only nag user about disabled achievements when they were actually enabled before.	2023-12-10 21:10:49 +01:00
JosJuice	c55f21729f	Add "large entry points map" setting ... To aid in debugging, this makes it possible to disable the recently added 32/64 GiB region which hasn't had a proper name so far.	2023-12-10 21:07:27 +01:00
JosJuice	0ec12f9e7e	JitArm64: Add additional condition for lmw/stmw a discard ... If a is one of the registers that will be loaded/stored, we must not discard it early. Sorry for this fixup of a fixup...	2023-12-10 19:13:35 +01:00
JosJuice	13a4f1b799	JitArm64: Guard against discarding a in lmw/stmw ... If a_is_addr_base_reg is true, discarding a before the end of the instruction would result in the instruction being miscompiled.	2023-12-10 17:58:15 +01:00
Lioncash	f4b1a199e8	VFFUtil: Use std::span with WriteToVFF ... Same behavior, but allows different containers to be used. In one case it also gets rid of needing to construct a std::vector.	2023-12-10 10:17:39 -05:00
Mai	e2472e4f50	Merge pull request #12352 from JosJuice/jitarm64-flush-in-long-inst ... JitArm64: Flush in the middle of lmw/stmw/mfcr	2023-12-10 09:15:07 -05:00
Mai	f249e414ad	Merge pull request #12366 from AdmiralCurtiss/exi-ipl-fixes ... HW/CEXIIPL: Various fixes.	2023-12-10 09:12:18 -05:00
Admiral H. Curtiss	a0da6788a3	MMU: Use MSR.IR for instruction reads.	2023-12-10 14:18:25 +01:00
Admiral H. Curtiss	c12725c916	MMU: Assert that the given XCheckTLBFlag is valid for the operation.	2023-12-10 14:18:25 +01:00
Admiral H. Curtiss	0d6a0724fd	MMU: Always use data read for the PTE lookup in TranslatePageAddress.	2023-12-10 14:18:24 +01:00
Admiral H. Curtiss	5d2fc0147e	MMU: Mark IsOpcodeFlag() and IsNoExceptionFlag() as constexpr.	2023-12-10 14:18:24 +01:00