mirror of
https://github.com/dolphin-emu/dolphin.git
synced 2025-01-10 16:19:28 +01:00
04db3d5a50
Using `EXPECT_EQ` with boolean literals can cause a warning in certain versions of GCC. See https://github.com/google/googletest/issues/322 Fixes warnings: ``` ../Source/UnitTests/Common/BitSetTest.cpp: In member function 'virtual void BitSet_Basics_Test::TestBody()': ../Source/UnitTests/Common/BitSetTest.cpp:15:165: error: converting 'false' to pointer type for argument 1 of 'char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)' [-Werror=conversion-null] ../Source/UnitTests/Common/BitSetTest.cpp: In member function 'virtual void BitSet_BitGetSet_Test::TestBody()': ../Source/UnitTests/Common/BitSetTest.cpp:27:165: error: converting 'false' to pointer type for argument 1 of 'char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)' [-Werror=conversion-null] ../Source/UnitTests/Common/StringUtilTest.cpp: In member function 'virtual void StringUtil_StringBeginsWith_Test::TestBody()': ../Source/UnitTests/Common/StringUtilTest.cpp:23:165: error: converting 'false' to pointer type for argument 1 of 'char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)' [-Werror=conversion-null] ../Source/UnitTests/Common/StringUtilTest.cpp:25:165: error: converting 'false' to pointer type for argument 1 of 'char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)' [-Werror=conversion-null] ../Source/UnitTests/Common/StringUtilTest.cpp:26:165: error: converting 'false' to pointer type for argument 1 of 'char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)' [-Werror=conversion-null] ../Source/UnitTests/Common/StringUtilTest.cpp:27:165: error: converting 'false' to pointer type for argument 1 of 'char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)' [-Werror=conversion-null] ../Source/UnitTests/Common/StringUtilTest.cpp: In member function 'virtual void StringUtil_StringEndsWith_Test::TestBody()': ../Source/UnitTests/Common/StringUtilTest.cpp:35:165: error: converting 'false' to pointer type for argument 1 of 'char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)' [-Werror=conversion-null] ../Source/UnitTests/Common/StringUtilTest.cpp:37:165: error: converting 'false' to pointer type for argument 1 of 'char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)' [-Werror=conversion-null] ../Source/UnitTests/Common/StringUtilTest.cpp:38:165: error: converting 'false' to pointer type for argument 1 of 'char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)' [-Werror=conversion-null] ../Source/UnitTests/Common/StringUtilTest.cpp:39:165: error: converting 'false' to pointer type for argument 1 of 'char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)' [-Werror=conversion-null] c ```
43 lines
1.2 KiB
C++
43 lines
1.2 KiB
C++
// Copyright 2016 Dolphin Emulator Project
|
|
// Licensed under GPLv2+
|
|
// Refer to the license.txt file included.
|
|
|
|
#include <gtest/gtest.h>
|
|
#include <string>
|
|
#include <vector>
|
|
|
|
#include "Common/StringUtil.h"
|
|
|
|
TEST(StringUtil, JoinStrings)
|
|
{
|
|
EXPECT_EQ("", JoinStrings({}, ", "));
|
|
EXPECT_EQ("a", JoinStrings({"a"}, ","));
|
|
EXPECT_EQ("ab", JoinStrings({"a", "b"}, ""));
|
|
EXPECT_EQ("a, bb, c", JoinStrings({"a", "bb", "c"}, ", "));
|
|
EXPECT_EQ("???", JoinStrings({"?", "?"}, "?"));
|
|
}
|
|
|
|
TEST(StringUtil, StringBeginsWith)
|
|
{
|
|
EXPECT_TRUE(StringBeginsWith("abc", "a"));
|
|
EXPECT_FALSE(StringBeginsWith("abc", "b"));
|
|
EXPECT_TRUE(StringBeginsWith("abc", "ab"));
|
|
EXPECT_FALSE(StringBeginsWith("a", "ab"));
|
|
EXPECT_FALSE(StringBeginsWith("", "a"));
|
|
EXPECT_FALSE(StringBeginsWith("", "ab"));
|
|
EXPECT_TRUE(StringBeginsWith("abc", ""));
|
|
EXPECT_TRUE(StringBeginsWith("", ""));
|
|
}
|
|
|
|
TEST(StringUtil, StringEndsWith)
|
|
{
|
|
EXPECT_TRUE(StringEndsWith("abc", "c"));
|
|
EXPECT_FALSE(StringEndsWith("abc", "b"));
|
|
EXPECT_TRUE(StringEndsWith("abc", "bc"));
|
|
EXPECT_FALSE(StringEndsWith("a", "ab"));
|
|
EXPECT_FALSE(StringEndsWith("", "a"));
|
|
EXPECT_FALSE(StringEndsWith("", "ab"));
|
|
EXPECT_TRUE(StringEndsWith("abc", ""));
|
|
EXPECT_TRUE(StringEndsWith("", ""));
|
|
}
|