mirror of
https://github.com/dolphin-emu/dolphin.git
synced 2025-01-12 17:19:10 +01:00
a6649da088
This changes the read request handler to work just like IOS: * To make things clearer, we now return early from error conditions, instead of having nested ifs. * IOS does an additional check on the requested read length, and substracts the current seek position from it, if the read would cause IOS to read past the EOF (not sure what the purpose of this check is, but IOS does it, so we should too). * The most significant one: IOS does *not* return the requested read length, or update the file seek position with it. Instead, it uses the *actual* read length. As a result of simply doing what IOS does, this fixes _Mushroom Men_. The game creates a save file, reads 2560 bytes from it, then immediately writes 16384 bytes to it. With IOS, the first read does not change the seek position at all, so the save data is written at offset 0, not 2560. With Dolphin, the read erroneously set the seek position to 2560, which caused the data to be written at the wrong location. Behavior confirmed by comparing IPC replies with IOS LLE and by looking at the FS module in IOS.