mirror of
https://github.com/dolphin-emu/dolphin.git
synced 2025-01-30 17:46:48 +01:00
5021a13aa9
A voice is considered running if and only if `running` equals 1, not if `running` is not equal to 0. This fixes https://bugs.dolphin-emu.org/issues/12508 because for some reason *The Sims 2 - Castaway* sets `running` to 8 when a stream finishes playing; previously our AX HLE would just loop the voice and eventually crash after accessing invalid memory addresses. Thanks to JMC47 and delroth's help, I've verified that this is the correct check for the following ucodes: GC: * 0x3ad3b7ac * 0x3daf59b9 * 0x4e8a8b21 * 0x07f88145 * 0xe2136399 * 0x3389a79e Wii: * 0x347112ba * 0xfa450138 * 0xadbc06bd And while I was fixing the running check, I noticed that the is_stream field was also being handled incorrectly, so I've fixed that as well.