mirror of
https://github.com/dolphin-emu/dolphin.git
synced 2025-03-10 19:47:40 +01:00
5395f21ae5
QCheckBox::toggled and other similar signals are used to save changes and to update widget status (such as enabled).. OnConfigChanged needs to load new values and trigger widget updates, but the new value shouldn't trigger a save. A save is unnecessary (the config has the correct values and the UI is being updated to those values) and it'd trigger another ConfigChanged signal. This commit blocks the save without blocking the signal entirely.
113 lines
2.6 KiB
C++
113 lines
2.6 KiB
C++
// Copyright 2024 Dolphin Emulator Project
|
|
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
|
|
#pragma once
|
|
|
|
#include <QFont>
|
|
#include <QMouseEvent>
|
|
|
|
#include "Common/Config/Enums.h"
|
|
#include "Common/Config/Layer.h"
|
|
#include "DolphinQt/Settings.h"
|
|
|
|
namespace Config
|
|
{
|
|
template <typename T>
|
|
class Info;
|
|
struct Location;
|
|
} // namespace Config
|
|
|
|
template <class Derived>
|
|
class ConfigControl : public Derived
|
|
{
|
|
public:
|
|
ConfigControl(const Config::Location& location, Config::Layer* layer)
|
|
: m_location(location), m_layer(layer)
|
|
{
|
|
ConnectConfig();
|
|
}
|
|
ConfigControl(const QString& label, const Config::Location& location, Config::Layer* layer)
|
|
: Derived(label), m_location(location), m_layer(layer)
|
|
{
|
|
ConnectConfig();
|
|
}
|
|
ConfigControl(const Qt::Orientation& orient, const Config::Location& location,
|
|
Config::Layer* layer)
|
|
: Derived(orient), m_location(location), m_layer(layer)
|
|
{
|
|
ConnectConfig();
|
|
}
|
|
|
|
const Config::Location GetLocation() const { return m_location; }
|
|
|
|
protected:
|
|
void ConnectConfig()
|
|
{
|
|
Derived::connect(&Settings::Instance(), &Settings::ConfigChanged, this, [this] {
|
|
QFont bf = Derived::font();
|
|
bf.setBold(IsConfigLocal());
|
|
Derived::setFont(bf);
|
|
|
|
// This isn't signal blocked because the UI may need to be updated.
|
|
m_updating = true;
|
|
OnConfigChanged();
|
|
m_updating = false;
|
|
});
|
|
}
|
|
|
|
template <typename T>
|
|
void SaveValue(const Config::Info<T>& setting, const T& value)
|
|
{
|
|
// Avoid OnConfigChanged -> option changed to current config's value -> unnecessary save ->
|
|
// ConfigChanged.
|
|
if (m_updating)
|
|
return;
|
|
|
|
if (m_layer != nullptr)
|
|
{
|
|
m_layer->Set(m_location, value);
|
|
Config::OnConfigChanged();
|
|
return;
|
|
}
|
|
|
|
Config::SetBaseOrCurrent(setting, value);
|
|
}
|
|
|
|
template <typename T>
|
|
const T ReadValue(const Config::Info<T>& setting) const
|
|
{
|
|
if (m_layer != nullptr)
|
|
return m_layer->Get(setting);
|
|
|
|
return Config::Get(setting);
|
|
}
|
|
|
|
virtual void OnConfigChanged(){};
|
|
|
|
private:
|
|
bool IsConfigLocal() const
|
|
{
|
|
if (m_layer != nullptr)
|
|
return m_layer->Exists(m_location);
|
|
else
|
|
return Config::GetActiveLayerForConfig(m_location) != Config::LayerType::Base;
|
|
}
|
|
|
|
void mousePressEvent(QMouseEvent* event) override
|
|
{
|
|
if (m_layer != nullptr && event->button() == Qt::RightButton)
|
|
{
|
|
m_layer->DeleteKey(m_location);
|
|
Config::OnConfigChanged();
|
|
}
|
|
else
|
|
{
|
|
Derived::mousePressEvent(event);
|
|
}
|
|
}
|
|
|
|
bool m_updating = false;
|
|
const Config::Location m_location;
|
|
Config::Layer* m_layer;
|
|
};
|