Lioncash
c85e0a2586
FramebufferManagerBase: Return a std::pair from GetTargetSize
...
Keeps associated data together. It also eliminates the possibility of out
parameters not being initialized properly. For example, consider the
following example:
-- some FramebufferManager implementation --
void FBMgrImpl::GetTargetSize(u32* width, u32* height) override
{
// Do nothing
}
-- somewhere else where the function is used --
u32 width, height;
framebuffer_manager_instance->GetTargetSize(&width, &height);
if (texture_width != width) <-- Uninitialized variable usage
{
...
}
It makes it much more obvious to spot any initialization issues, because
it requires something to be returned, as opposed to allowing an
implementation to just not do anything.
2017-02-03 15:27:53 -05:00
..
2017-01-23 03:53:38 -05:00
2017-01-05 12:55:13 +01:00
2017-01-29 22:05:12 -05:00
2017-01-29 22:05:12 -05:00
2016-06-24 10:43:46 +02:00
2016-06-24 10:43:46 +02:00
2016-11-27 22:38:38 +01:00
2016-06-24 10:43:46 +02:00
2017-01-23 16:05:32 -05:00
2017-01-23 16:07:03 -05:00
2017-01-23 12:41:26 -05:00
2016-01-17 20:11:45 -05:00
2017-01-06 14:01:36 +01:00
2017-01-27 19:04:56 +01:00
2017-01-27 19:04:56 +01:00
2016-06-24 10:43:46 +02:00
2016-06-24 10:43:46 +02:00
2017-01-05 12:55:13 +01:00
2016-06-24 10:43:46 +02:00
2016-06-24 12:16:10 +02:00
2016-06-24 10:43:46 +02:00
2016-10-31 15:02:08 +01:00
2016-10-31 15:02:08 +01:00
2017-01-27 19:04:56 +01:00
2016-10-08 11:49:51 -05:00
2016-06-24 10:43:46 +02:00
2016-06-24 10:43:46 +02:00
2017-02-03 15:27:53 -05:00
2017-02-03 15:27:53 -05:00
2017-02-01 12:19:55 -05:00
2017-02-01 12:19:55 -05:00
2016-12-10 17:33:51 -05:00
2016-06-26 12:34:59 +02:00
2016-10-29 15:24:02 +02:00
2016-06-24 10:43:46 +02:00
2016-10-08 12:02:49 +02:00
2016-10-08 12:02:49 +02:00
2016-06-24 10:43:46 +02:00
2016-06-24 10:43:46 +02:00
2017-02-01 12:19:55 -05:00
2017-02-01 01:06:00 -05:00
2016-06-24 10:43:46 +02:00
2017-01-23 03:53:38 -05:00
2016-06-26 16:13:19 +12:00
2016-10-15 12:44:37 +02:00
2016-10-15 12:44:37 +02:00
2017-01-27 19:04:56 +01:00
2016-06-26 12:34:59 +02:00
2016-06-24 10:43:46 +02:00
2016-06-24 10:43:46 +02:00
2017-01-27 07:49:47 +01:00
2017-01-05 12:55:13 +01:00
2017-02-01 01:06:00 -05:00
2017-01-04 20:02:31 +01:00
2016-12-10 17:33:51 -05:00
2016-06-26 12:34:59 +02:00
2016-06-24 10:43:46 +02:00
2016-06-24 10:43:46 +02:00
2017-02-03 15:27:53 -05:00
2017-01-28 13:02:54 +01:00
2017-01-06 14:01:39 +01:00
2017-01-06 14:01:36 +01:00
2016-06-24 10:43:46 +02:00
2015-05-25 13:22:31 +02:00
2017-02-01 12:19:55 -05:00
2016-07-29 19:20:16 -04:00
2016-06-24 10:43:46 +02:00
2016-12-27 17:26:04 +01:00
2016-12-27 17:26:04 +01:00
2016-10-01 01:09:11 +10:00
2016-07-29 19:20:16 -04:00
2017-01-15 20:23:26 +11:00
2017-01-15 20:23:26 +11:00
2017-01-15 20:23:26 +11:00
2017-01-15 20:23:26 +11:00
2017-01-15 20:23:26 +11:00
2016-06-24 10:43:46 +02:00
2016-01-17 20:11:45 -05:00
2016-06-24 10:43:46 +02:00
2016-06-24 10:43:46 +02:00
2016-06-24 10:43:46 +02:00
2016-06-24 10:43:46 +02:00
2016-06-24 10:43:46 +02:00
2016-06-24 10:43:46 +02:00
2016-09-17 16:47:12 +02:00
2016-06-24 10:43:46 +02:00
2016-09-27 18:45:14 +02:00
2016-06-24 10:43:46 +02:00
2016-06-24 10:43:46 +02:00
2016-06-24 10:43:46 +02:00
2016-10-08 11:49:51 -05:00
2016-10-08 11:49:51 -05:00
2016-06-24 10:43:46 +02:00
2016-12-04 13:09:16 +01:00
2016-06-24 10:43:46 +02:00
2017-01-23 12:41:26 -05:00
2017-01-04 20:02:31 +01:00
2017-02-01 12:19:55 -05:00
2017-01-13 14:01:17 +01:00
2017-01-13 14:01:17 +01:00
2016-06-26 12:34:59 +02:00
2016-10-06 16:53:55 -07:00
2017-01-27 19:04:56 +01:00
2016-10-01 01:09:11 +10:00
2017-01-06 14:01:36 +01:00
2017-01-15 20:23:26 +11:00
2017-01-21 11:31:44 +01:00
2016-11-28 20:14:59 +10:00
2016-08-21 23:30:38 -04:00
2016-06-26 12:34:59 +02:00
2016-01-17 20:11:45 -05:00
2017-01-05 12:55:13 +01:00
2016-10-01 15:50:28 -04:00
2015-05-25 13:22:31 +02:00