The-Homebrew-Cloud/libgui
2
0
Fork 0
mirror of https://github.com/wiiu-env/libgui.git synced 2024-11-14 12:25:10 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix stereo downmixing.

Browse Source 
Without this fix that happens:

======================== ASAN: out-of-bounds load
Source: 0x0D0254D8: homebrew_launcher|_ZN12SoundDecoder6DecodeEv
Bad load was on address 0x10CEE778. Guessing possible issues:
Guess     Chunk      ChunkSz    Dist       ChunkOwner
Overflow  0x10CEA760 0x00004000 0x00000018 homebrew_launcher|_ZN12BufferCircle6ResizeEi
Underflow 0x10CEE780 0x00004000 0xFFFFBFF8 homebrew_launcher|_ZN12BufferCircle6ResizeEi

With this fix playing a mono stream still produces clipping but without the fix it's completely garbled.

Signed-off-by: Thomas Rohloff <v10lator@myway.de>
This commit is contained in:
Thomas Rohloff 2020-05-06 18:40:24 +02:00
parent 45bad52a0c
commit 9f31af87f8
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
source/sounds/SoundDecoder.cpp
View File

@ -186,12 +186,15 @@ void SoundDecoder::Decode() {
}
//! TODO: remove this later and add STEREO support with two voices, for now we convert to MONO
done >>= 1;
if(IsStereo()) {
int16_t* monoBuf = (int16_t*)write_buf;
done = done >> 1;
done >>= 1;
for(int32_t i = 0; i < done; i++)
monoBuf[i] = monoBuf[i << 1];
done <<= 1;
}
DCFlushRange(write_buf, done);