From 5c4ba5c207e794ffe84af3ad347b8ec2015e247c Mon Sep 17 00:00:00 2001 From: Christopher Roy Bratusek Date: Fri, 5 Aug 2016 21:08:51 +0200 Subject: [PATCH] pokemon*.sh: minor fixes and code review --- script.d/pokemon/pokemoneternalx.sh | 8 ++++---- script.d/pokemon/pokemonneox.sh | 2 +- script.d/pokemon/pokemonneoy.sh | 2 +- script.d/pokemon/pokemonrutileruby.sh | 2 +- script.d/pokemon/pokemonstarsapphire.sh | 4 ++-- script.d/pokemon/pokemonwiltingy.sh | 4 ++-- 6 files changed, 11 insertions(+), 11 deletions(-) diff --git a/script.d/pokemon/pokemoneternalx.sh b/script.d/pokemon/pokemoneternalx.sh index 9f955e1..96b7938 100644 --- a/script.d/pokemon/pokemoneternalx.sh +++ b/script.d/pokemon/pokemoneternalx.sh @@ -36,9 +36,9 @@ viola_nerf () { enter either 'nerf' or press [Enter] to keep: " - read choice + read -r choice - case choice in + case ${choice} in [nN]erf ) HANS_EXTRA_PATH="${HANS_PATH}/Viola Nerf Files" ;; * ) echo "invalid choice made, keeping first gym leader's team strength" ;; esac @@ -63,14 +63,14 @@ Encounter type changes the wild Pokemon availability: enter either 'legal', 'rebalanced' or 'insanity': " - read choice + read -r choice case ${choice} in [lL]egal ) HANS_PATH="${RIIVOLUTION_DIR}/Legal version" viola_nerf ;; [rR]ebalanced ) HANS_PATH="${RIIVOLUTION_DIR}/Rebalanced version" viola_nerf ;; - [iI]nsanity ) HANS_PATH="${RIIVOLUTION_DIR}/Insanity Mode" + [iI]nsanity ) HANS_PATH="${RIIVOLUTION_DIR}/Insanity Mode" ;; * ) echo "invalid choice made, using 'Rebalanced version'." HANS_PATH="${RIIVOLUTION_DIR}/Rebalanced version" viola_nerf ;; diff --git a/script.d/pokemon/pokemonneox.sh b/script.d/pokemon/pokemonneox.sh index 851f7a2..12af0a8 100644 --- a/script.d/pokemon/pokemonneox.sh +++ b/script.d/pokemon/pokemonneox.sh @@ -41,7 +41,7 @@ check_hans_files () { enter either 'full' or 'lite': " - read choice + read -r choice case ${choice} in [fF]ull ) HANS_PATH="${RIIVOLUTION_DIR}"/Full/romfs ;; diff --git a/script.d/pokemon/pokemonneoy.sh b/script.d/pokemon/pokemonneoy.sh index 6543b31..d72e858 100644 --- a/script.d/pokemon/pokemonneoy.sh +++ b/script.d/pokemon/pokemonneoy.sh @@ -41,7 +41,7 @@ check_hans_files () { enter either 'full' or 'lite': " - read choice + read -r choice case ${choice} in [fF]ull ) HANS_PATH="${RIIVOLUTION_DIR}"/Full/romfs ;; diff --git a/script.d/pokemon/pokemonrutileruby.sh b/script.d/pokemon/pokemonrutileruby.sh index bff7398..18d9c1a 100644 --- a/script.d/pokemon/pokemonrutileruby.sh +++ b/script.d/pokemon/pokemonrutileruby.sh @@ -52,7 +52,7 @@ Encounter type changes the wild Pokemon availability: enter either 'legit', 'leveled' or '679': " - read choice + read -r choice case ${choice} in [lL]egit ) HANS_EXTRA_PATH="${RIIVOLUTION_DIR}/Encounter Type/Legit Build" ;; diff --git a/script.d/pokemon/pokemonstarsapphire.sh b/script.d/pokemon/pokemonstarsapphire.sh index 74a1b0a..202f724 100644 --- a/script.d/pokemon/pokemonstarsapphire.sh +++ b/script.d/pokemon/pokemonstarsapphire.sh @@ -25,7 +25,7 @@ edited, and the level curve expects use of the Experience Share, which means that you level up very quickly. You should be hitting Level 100 by the time you get to the Elite Four. -Source: https://projectpokemon.org/forums/showthread.php?46315 +Source: https://projectpokemon.org/forums/showthread -r.php?46315 Base ROM: Pokemon Alpha Sapphire Supported Versions: US, EU, JAP ************************************************" @@ -52,7 +52,7 @@ Encounter type changes the wild Pokemon availability: enter either 'legit', 'leveled' or '679': " - read choice + read -r choice case ${choice} in [lL]egit ) HANS_EXTRA_PATH="${RIIVOLUTION_DIR}/Encounter Type/Legit Build" ;; diff --git a/script.d/pokemon/pokemonwiltingy.sh b/script.d/pokemon/pokemonwiltingy.sh index 041e8cd..f847714 100644 --- a/script.d/pokemon/pokemonwiltingy.sh +++ b/script.d/pokemon/pokemonwiltingy.sh @@ -36,7 +36,7 @@ viola_nerf () { enter either 'nerf' or press [Enter] to keep: " - read choice + read -r choice case choice in [nN]erf ) HANS_EXTRA_PATH="${HANS_PATH}/Viola Nerf Files" ;; @@ -63,7 +63,7 @@ Encounter type changes the wild Pokemon availability: enter either 'legal', 'rebalanced' or 'insanity': " - read choice + read -r choice case ${choice} in [lL]egal ) HANS_PATH="${RIIVOLUTION_DIR}/Legal version"