From 08bbc66b09d38d88700100102803e1fc2cbcd5de Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E2=97=B1=20PixelyIon?= Date: Sat, 15 Feb 2020 15:08:17 +0530 Subject: [PATCH] Fix CR issues and Game Duplication + Move to Vector for Memory Map This commit fixed the issues outlined in the CR (Mainly correlated to formatting), moves to a sorted vector from a sorted list for the memory map in addition to using binary search for sorting through rather than iteratively and fixes item duplication in the game list when directory is changed in Settings. --- .idea/codeStyles/Project.xml | 1 + app/src/main/AndroidManifest.xml | 12 +- app/src/main/cpp/skyline/common.cpp | 6 +- app/src/main/cpp/skyline/common.h | 12 +- app/src/main/cpp/skyline/gpu.cpp | 2 +- .../skyline/gpu/devices/nvhost_channel.cpp | 2 +- .../skyline/gpu/devices/nvhost_ctrl_gpu.cpp | 4 +- .../main/cpp/skyline/gpu/devices/nvmap.cpp | 12 +- app/src/main/cpp/skyline/gpu/display.cpp | 7 +- app/src/main/cpp/skyline/gpu/display.h | 5 +- app/src/main/cpp/skyline/kernel/ipc.cpp | 124 ++++++++--------- app/src/main/cpp/skyline/kernel/ipc.h | 44 +++--- app/src/main/cpp/skyline/kernel/memory.cpp | 130 ++++++++++-------- app/src/main/cpp/skyline/kernel/memory.h | 23 ++-- app/src/main/cpp/skyline/kernel/svc.cpp | 15 +- .../skyline/kernel/types/KPrivateMemory.cpp | 5 +- .../cpp/skyline/kernel/types/KProcess.cpp | 16 ++- .../main/cpp/skyline/kernel/types/KProcess.h | 121 +++++++++++----- .../skyline/kernel/types/KSharedMemory.cpp | 19 +-- .../main/cpp/skyline/kernel/types/KThread.cpp | 2 +- .../main/cpp/skyline/kernel/types/KThread.h | 2 +- .../skyline/kernel/types/KTransferMemory.cpp | 10 +- app/src/main/cpp/skyline/nce.cpp | 44 ++---- app/src/main/cpp/skyline/nce/guest.S | 30 +++- app/src/main/cpp/skyline/nce/guest.cpp | 70 +++++----- app/src/main/cpp/skyline/nce/guest.h | 10 +- app/src/main/cpp/skyline/nce/guest_common.h | 10 +- app/src/main/cpp/skyline/os.cpp | 2 +- app/src/main/cpp/skyline/services/hid/hid.cpp | 2 +- .../main/cpp/skyline/services/nvdrv/nvdrv.cpp | 3 +- app/src/main/java/emu/skyline/MainActivity.kt | 28 ++-- 31 files changed, 418 insertions(+), 355 deletions(-) diff --git a/.idea/codeStyles/Project.xml b/.idea/codeStyles/Project.xml index a4a819fd..30c29deb 100644 --- a/.idea/codeStyles/Project.xml +++ b/.idea/codeStyles/Project.xml @@ -20,6 +20,7 @@