From 15e9fa1c80b8ff882ebf49bc48d0b115187b4f7b Mon Sep 17 00:00:00 2001
From: Billy Laws <blaws05@gmail.com>
Date: Tue, 10 May 2022 18:28:15 +0100
Subject: [PATCH] Fix FillRandomBytes

There were two issues here:
- If a skyline span was passed as a param then the 'T &object' version would be called, filling the span itself with random values rather than its contents
- Random numbers were repeated every call since independent_bits_engine copied generator state and thus it was never actually updated
---
 app/src/main/cpp/skyline/common/utils.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/app/src/main/cpp/skyline/common/utils.h b/app/src/main/cpp/skyline/common/utils.h
index f8c6b390..1ced47a3 100644
--- a/app/src/main/cpp/skyline/common/utils.h
+++ b/app/src/main/cpp/skyline/common/utils.h
@@ -237,12 +237,12 @@ namespace skyline::util {
     template<typename T>
     requires std::is_integral_v<T>
     void FillRandomBytes(std::span<T> in) {
-        std::independent_bits_engine<std::mt19937_64, std::numeric_limits<T>::digits, T> gen(detail::generator);
-        std::generate(in.begin(), in.end(), gen);
+        std::uniform_int_distribution<u64> dist(std::numeric_limits<T>::min(), std::numeric_limits<T>::max());
+        std::generate(in.begin(), in.end(), [&]() { return dist(detail::generator); });
     }
 
     template<class T>
-    requires (!std::is_integral_v<T> && std::is_trivially_copyable_v<T>)
+    requires (std::is_trivially_copyable_v<T> && !requires (T v) { v.data(); })
     void FillRandomBytes(T &object) {
         FillRandomBytes(std::span(reinterpret_cast<typename IntegerFor<T>::Type *>(&object), IntegerFor<T>::Count));
     }