The-Homebrew-Cloud/skyline
2
0
Fork 0
mirror of https://github.com/skyline-emu/skyline.git synced 2024-12-23 17:51:52 +01:00
Code Issues Packages Projects Releases Wiki Activity

Null-Check Optional NACP before extracting application title

Browse Source 
Not doing this can lead to the NACP being filled with invalid data and led to crashes on homebrew titles like SpaceNX.
This commit is contained in:
PixelyIon 2021-10-16 13:01:35 +01:00
parent c8821c7313
commit 1d532628cb
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/src/main/cpp/skyline/loader/nro.cpp
View File

@ -64,7 +64,7 @@ namespace skyline::loader {
} }
state.process->memory.InitializeVmm(memory::AddressSpaceType::AddressSpace39Bit); state.process->memory.InitializeVmm(memory::AddressSpaceType::AddressSpace39Bit);
auto applicationName{nacp->GetApplicationName(nacp->GetFirstSupportedTitleLanguage())}; auto applicationName{nacp ? nacp->GetApplicationName(nacp->GetFirstSupportedTitleLanguage()) : ""};
auto loadInfo{LoadExecutable(process, state, executable, 0, applicationName.empty() ? "main.nro" : applicationName + ".nro")}; auto loadInfo{LoadExecutable(process, state, executable, 0, applicationName.empty() ? "main.nro" : applicationName + ".nro")};
state.process->memory.InitializeRegions(loadInfo.base, loadInfo.size); state.process->memory.InitializeRegions(loadInfo.base, loadInfo.size);