From 35717373926c6892c382ffc412d85c5fc8563ea7 Mon Sep 17 00:00:00 2001 From: Billy Laws Date: Tue, 27 Dec 2022 19:05:20 +0000 Subject: [PATCH] Reset maxwell3d quick bind state before adding subpasses to executor If a submission happens during the call to addsubpass we could end up with invalid quick bind state, move this to to before to prevent that. --- .../cpp/skyline/gpu/interconnect/maxwell_3d/maxwell_3d.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/src/main/cpp/skyline/gpu/interconnect/maxwell_3d/maxwell_3d.cpp b/app/src/main/cpp/skyline/gpu/interconnect/maxwell_3d/maxwell_3d.cpp index 337871ae..8b099fba 100644 --- a/app/src/main/cpp/skyline/gpu/interconnect/maxwell_3d/maxwell_3d.cpp +++ b/app/src/main/cpp/skyline/gpu/interconnect/maxwell_3d/maxwell_3d.cpp @@ -304,6 +304,8 @@ namespace skyline::gpu::interconnect::maxwell3d { } } + constantBuffers.ResetQuickBind(); + ctx.executor.AddSubpass([drawParams](vk::raii::CommandBuffer &commandBuffer, const std::shared_ptr &, GPU &gpu, vk::RenderPass, u32) { drawParams->stateUpdater.RecordAll(gpu, commandBuffer); @@ -319,6 +321,5 @@ namespace skyline::gpu::interconnect::maxwell3d { commandBuffer.endTransformFeedbackEXT(0, {}, {}); }, scissor, activeDescriptorSetSampledImages, {}, activeState.GetColorAttachments(), activeState.GetDepthAttachment(), !ctx.gpu.traits.quirks.relaxedRenderPassCompatibility); - constantBuffers.ResetQuickBind(); } } \ No newline at end of file