The-Homebrew-Cloud/skyline
2
0
Fork 0
mirror of https://github.com/skyline-emu/skyline.git synced 2024-12-23 14:21:52 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add double-insertion debug check to InsertThread

Browse Source 
This is a cause for a large amount of scheduler bugs so we should generally check for this on debug builds as it is a fairly easy way to check for issues for some performance cost.
This commit is contained in:
PixelyIon 2022-11-26 01:49:55 +05:30 committed by Mark Collins
parent 5694c9b34b
commit 4df3c98225
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
app/src/main/cpp/skyline/kernel/scheduler.cpp
View File

@ -95,6 +95,16 @@ namespace skyline::kernel {
thread->scheduleCondition.wait(lock, [&]() { return !thread->isPaused; });
}
#ifndef NDEBUG
// Scan the queue for the same thread to prevent double insertion
for (auto &residentThread : core.queue) {
if (residentThread == thread) {
Logger::Error("T{} already exists in C{}", thread->id, core.id);
Logger::EmulationContext.Flush();
}
}
#endif
auto nextThread{std::upper_bound(core.queue.begin(), core.queue.end(), thread->priority.load(), type::KThread::IsHigherPriority)};
if (nextThread == core.queue.begin()) {
if (nextThread != core.queue.end()) {