The-Homebrew-Cloud/skyline
2
0
Fork 0
mirror of https://github.com/skyline-emu/skyline.git synced 2024-11-04 21:15:10 +01:00
Code Issues Packages Projects Releases Wiki Activity

Correctly save/restore ROM version to/from game entry cache

Browse Source 
PR #1758 introduced a bug where the game list would be entirely loaded every time the app was opened. This commit addresses that issue, which was caused by the `version` member of the cached game list being serialized to file (although incorrectly) but never actually read back when deserializing.
This commit is contained in:
lynxnb 2022-08-21 20:24:36 +02:00
parent cfa5f0e030
commit 5d6eaee301
1 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
app/src/main/java/emu/skyline/loader/RomFile.kt
View File

@ -63,7 +63,15 @@ enum class LoaderResult(val value : Int) {
/**
* This class is used to hold an application's metadata in a serializable way
*/
data class AppEntry(var name : String, var author : String?, var icon : Bitmap?, var version : String?, var format : RomFormat, var uri : Uri, var loaderResult : LoaderResult) : Serializable {
data class AppEntry(
var name : String,
var author : String?,
var icon : Bitmap?,
var version : String?,
var format : RomFormat,
var uri : Uri,
var loaderResult : LoaderResult
) : Serializable {
constructor(context : Context, format : RomFormat, uri : Uri, loaderResult : LoaderResult) : this(context.contentResolver.query(uri, null, null, null, null)?.use { cursor ->
val nameIndex : Int = cursor.getColumnIndex(OpenableColumns.DISPLAY_NAME)
cursor.moveToFirst()
@ -77,6 +85,7 @@ data class AppEntry(var name : String, var author : String?, var icon : Bitmap?,
output.writeBoolean(author != null)
if (author != null)
output.writeUTF(author)
output.writeBoolean(version != null)
if (version != null)
output.writeUTF(version)
output.writeInt(loaderResult.value)
@ -96,10 +105,19 @@ data class AppEntry(var name : String, var author : String?, var icon : Bitmap?,
uri = Uri.parse(input.readUTF())
if (input.readBoolean())
author = input.readUTF()
if (input.readBoolean())
version = input.readUTF()
loaderResult = LoaderResult.get(input.readInt())
if (input.readBoolean())
icon = BitmapFactory.decodeStream(input)
}
companion object {
/*
* The serialization version must be incremented after any changes to this class
*/
private const val serialVersionUID : Long = 1L
}
}
/**