diff --git a/app/src/main/cpp/skyline/gpu/interconnect/maxwell_3d/constant_buffers.cpp b/app/src/main/cpp/skyline/gpu/interconnect/maxwell_3d/constant_buffers.cpp index e4faffee..4a08aa18 100644 --- a/app/src/main/cpp/skyline/gpu/interconnect/maxwell_3d/constant_buffers.cpp +++ b/app/src/main/cpp/skyline/gpu/interconnect/maxwell_3d/constant_buffers.cpp @@ -33,16 +33,6 @@ namespace skyline::gpu::interconnect::maxwell3d { view.PurgeCaches(); } - static void FlushHostCallback() { - // TODO: here we should trigger `Execute()`, however that doesn't currently work due to Read being called mid-draw and attached objects not handling this case - Logger::Warn("GPU dirty buffer reads for attached buffers are unimplemented"); - } - - void ConstantBuffer::Read(CommandExecutor &executor, span dstBuffer, size_t srcOffset) { - ContextLock lock{executor.tag, view}; - view.Read(lock.IsFirstUsage(), FlushHostCallback, dstBuffer, srcOffset); - } - ConstantBuffers::ConstantBuffers(DirtyManager &manager, const ConstantBufferSelectorState::EngineRegisters &constantBufferSelectorRegisters) : selectorState{manager, constantBufferSelectorRegisters} {} void ConstantBuffers::MarkAllDirty() { diff --git a/app/src/main/cpp/skyline/gpu/interconnect/maxwell_3d/constant_buffers.h b/app/src/main/cpp/skyline/gpu/interconnect/maxwell_3d/constant_buffers.h index 46079295..903bf83d 100644 --- a/app/src/main/cpp/skyline/gpu/interconnect/maxwell_3d/constant_buffers.h +++ b/app/src/main/cpp/skyline/gpu/interconnect/maxwell_3d/constant_buffers.h @@ -29,19 +29,6 @@ namespace skyline::gpu::interconnect::maxwell3d { void PurgeCaches(); }; - struct ConstantBuffer { - BufferView view; - - void Read(CommandExecutor &executor, span dstBuffer, size_t srcOffset); - - template - T Read(CommandExecutor &executor, size_t srcOffset) { - T object; - Read(executor, span{object}.template cast(), srcOffset); - return object; - } - }; - using ConstantBufferSet = std::array, engine::ShaderStageCount>; /**