From 7fef849594e933954849a2ffc6410c8170c1761a Mon Sep 17 00:00:00 2001 From: PixelyIon Date: Wed, 30 Nov 2022 03:51:45 +0530 Subject: [PATCH] Make `UpdateCore`'s locking `coreMigrationMutex` requirement explicit `Scheduler::UpdateCore` implicitly depended on `KThread::coreMigrationMutex` being locked during calls to it, this requirement has now been made explicit to avoid confusion. --- app/src/main/cpp/skyline/kernel/scheduler.h | 1 + 1 file changed, 1 insertion(+) diff --git a/app/src/main/cpp/skyline/kernel/scheduler.h b/app/src/main/cpp/skyline/kernel/scheduler.h index ab3d5ad3..073a744f 100644 --- a/app/src/main/cpp/skyline/kernel/scheduler.h +++ b/app/src/main/cpp/skyline/kernel/scheduler.h @@ -129,6 +129,7 @@ namespace skyline { /** * @brief Updates the core that the supplied thread is resident to according to its new affinity mask and ideal core * @note This supports changing the core of a thread which is currently running + * @note 'KThread::coreMigrationMutex' **must** be locked by the calling thread prior to calling this */ void UpdateCore(const std::shared_ptr &thread);