The-Homebrew-Cloud/skyline
2
0
Fork 0
mirror of https://github.com/skyline-emu/skyline.git synced 2024-12-23 12:41:50 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix MoveRegister to clear when value is 0

Browse Source 
The register wouldn't be cleared with a `MOVZ` when a value was zero due to the condition for writing an instruction requiring the `offsetValue` to be non-zero.
This commit is contained in:
PixelyIon 2022-11-05 21:52:27 +05:30
parent f7ab3abb86
commit 8892eb08e6
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
app/src/main/cpp/skyline/nce/instructions.h
View File

@ -257,13 +257,11 @@ namespace skyline::nce {
for (auto &instruction : instructions) {
auto offsetValue{*(valuePointer + offset)};
if (offsetValue) {
if (zeroed) {
instruction = instructions::Movk(destination, offsetValue, offset).raw;
} else {
instruction = instructions::Movz(destination, offsetValue, offset).raw;
zeroed = true;
}
if (!zeroed) {
instruction = instructions::Movz(destination, offsetValue, offset).raw;
zeroed = true;
} else if (offsetValue && zeroed) {
instruction = instructions::Movk(destination, offsetValue, offset).raw;
} else {
instruction = 0;
}