The-Homebrew-Cloud/skyline
2
0
Fork 0
mirror of https://github.com/skyline-emu/skyline.git synced 2024-11-26 18:14:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix slight locking bug with nvmap handle duplication

Browse Source
This commit is contained in:
Billy Laws 2022-05-12 17:12:24 +01:00
parent 57378457dc
commit 97e740c986
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/src/main/cpp/skyline/services/nvdrv/core/nvmap.cpp
View File

@ -40,12 +40,12 @@ namespace skyline::service::nvdrv::core {
} }
PosixResult NvMap::Handle::Duplicate(bool internalSession) { PosixResult NvMap::Handle::Duplicate(bool internalSession) {
std::scoped_lock lock(mutex);
// Unallocated handles cannot be duplicated as duplication requires memory accounting (in HOS) // Unallocated handles cannot be duplicated as duplication requires memory accounting (in HOS)
if (!allocated) [[unlikely]] if (!allocated) [[unlikely]]
return PosixResult::InvalidArgument; return PosixResult::InvalidArgument;
std::scoped_lock lock(mutex);
// If we internally use FromId the duplication tracking of handles won't work accurately due to us not implementing // If we internally use FromId the duplication tracking of handles won't work accurately due to us not implementing
// per-process handle refs. // per-process handle refs.
if (internalSession) if (internalSession)