From a16383fd4b443e10f5bea02f2844d2000568db73 Mon Sep 17 00:00:00 2001 From: Billy Laws Date: Sat, 19 Nov 2022 20:20:27 +0000 Subject: [PATCH] Disable compute shaders on mali This will need to be debugged properly at some point but its fine for now. --- .../skyline/gpu/interconnect/kepler_compute/kepler_compute.cpp | 3 +++ app/src/main/cpp/skyline/gpu/trait_manager.cpp | 1 + app/src/main/cpp/skyline/gpu/trait_manager.h | 1 + 3 files changed, 5 insertions(+) diff --git a/app/src/main/cpp/skyline/gpu/interconnect/kepler_compute/kepler_compute.cpp b/app/src/main/cpp/skyline/gpu/interconnect/kepler_compute/kepler_compute.cpp index 998a1165..1d3b7576 100644 --- a/app/src/main/cpp/skyline/gpu/interconnect/kepler_compute/kepler_compute.cpp +++ b/app/src/main/cpp/skyline/gpu/interconnect/kepler_compute/kepler_compute.cpp @@ -28,6 +28,9 @@ namespace skyline::gpu::interconnect::kepler_compute { } void KeplerCompute::Dispatch(const QMD &qmd) { + if (ctx.gpu.traits.quirks.brokenComputeShaders) + return; + StateUpdateBuilder builder{*ctx.executor.allocator}; constantBuffers.Update(ctx, qmd); diff --git a/app/src/main/cpp/skyline/gpu/trait_manager.cpp b/app/src/main/cpp/skyline/gpu/trait_manager.cpp index 2bb355de..5fd3945a 100644 --- a/app/src/main/cpp/skyline/gpu/trait_manager.cpp +++ b/app/src/main/cpp/skyline/gpu/trait_manager.cpp @@ -239,6 +239,7 @@ namespace skyline::gpu { case vk::DriverId::eArmProprietary: { maxGlobalPriority = vk::QueueGlobalPriorityEXT::eHigh; + brokenComputeShaders = true; break; } diff --git a/app/src/main/cpp/skyline/gpu/trait_manager.h b/app/src/main/cpp/skyline/gpu/trait_manager.h index 02d09e22..227fbac8 100644 --- a/app/src/main/cpp/skyline/gpu/trait_manager.h +++ b/app/src/main/cpp/skyline/gpu/trait_manager.h @@ -64,6 +64,7 @@ namespace skyline::gpu { bool relaxedRenderPassCompatibility{}; //!< [Adreno Proprietary/Freedreno] A relaxed version of Vulkan specification's render pass compatibility clause which allows for caching pipeline objects for multi-subpass renderpasses, this is intentionally disabled by default as it requires testing prior to enabling bool brokenPushDescriptors{}; //!< [Adreno Proprietary] A bug that causes push descriptor updates to ignored by the driver in certain situations bool brokenSpirvPositionInput{}; //!< [Adreno Proprietary] A bug that causes the shader compiler to fail on shaders with vertex position inputs not contained within a struct + bool brokenComputeShaders{}; //!< [ARM Proprietary] A bug that causes compute shaders in some games to crash the GPU u32 maxSubpassCount{std::numeric_limits::max()}; //!< The maximum amount of subpasses within a renderpass, this is limited to 64 on older Adreno proprietary drivers vk::QueueGlobalPriorityEXT maxGlobalPriority{vk::QueueGlobalPriorityEXT::eMedium}; //!< The highest allowed global priority of the queue, drivers will not allow higher priorities to be set on queues