Move Kotlin settings to a dedicate package

2023-02-14 14:17:17 +01:00 · 2023-02-14 14:17:17 +01:00 · a1ca84f95e
parent 180d1efd4d
commit a1ca84f95e
17 changed files with 27 additions and 23 deletions
--- a/.idea/runConfigurations/Settings.xml
+++ b/.idea/runConfigurations/Settings.xml
@ -50,7 +50,7 @@
      <option name="NATIVE_MEMORY_SAMPLE_RATE_BYTES" value="2048" />
    </Profilers>
    <option name="DEEP_LINK" value="" />
-    <option name="ACTIVITY_CLASS" value="emu.skyline.SettingsActivity" />
+    <option name="ACTIVITY_CLASS" value="emu.skyline.settings.SettingsActivity" />
    <option name="SEARCH_ACTIVITY_IN_GLOBAL_SCOPE" value="false" />
    <option name="SKIP_ACTIVITY_VALIDATION" value="false" />
    <method v="2">
--- a/app/src/main/AndroidManifest.xml
+++ b/app/src/main/AndroidManifest.xml
@ -37,7 +37,7 @@
        </activity>

        <activity
-            android:name=".SettingsActivity"
+            android:name=".settings.SettingsActivity"
            android:exported="true"
            android:label="@string/settings"
            android:launchMode="singleTop"
@ -47,13 +47,13 @@
        <activity
            android:name=".input.ControllerActivity"
            android:exported="true"
-            android:parentActivityName=".SettingsActivity">
+            android:parentActivityName=".settings.SettingsActivity">
        </activity>

        <activity
            android:name=".preference.GpuDriverActivity"
            android:exported="true"
-            android:parentActivityName=".SettingsActivity">
+            android:parentActivityName=".settings.SettingsActivity">
        </activity>

        <activity
--- a/app/src/main/cpp/emu_jni.cpp
+++ b/app/src/main/cpp/emu_jni.cpp
@ -243,13 +243,13 @@ extern "C" JNIEXPORT void JNICALL Java_emu_skyline_input_InputHandler_00024Compa
    env->ReleaseIntArrayElements(pointsJni, reinterpret_cast<jint *>(points.data()), JNI_ABORT);
 }

-extern "C" JNIEXPORT void JNICALL Java_emu_skyline_utils_NativeSettings_updateNative(JNIEnv *env, jobject) {
+extern "C" JNIEXPORT void JNICALL Java_emu_skyline_settings_NativeSettings_updateNative(JNIEnv *env, jobject) {
    auto settings{SettingsWeak.lock()};
    if (!settings)
        return; // We don't mind if we miss settings updates while settings haven't been initialized
    settings->Update();
 }

-extern "C" JNIEXPORT void JNICALL Java_emu_skyline_utils_NativeSettings_00024Companion_setLogLevel(JNIEnv *, jobject, jint logLevel) {
+extern "C" JNIEXPORT void JNICALL Java_emu_skyline_settings_NativeSettings_00024Companion_setLogLevel(JNIEnv *, jobject, jint logLevel) {
    skyline::Logger::configLevel = static_cast<skyline::Logger::LogLevel>(logLevel);
 }
--- a/app/src/main/java/emu/skyline/EmulationActivity.kt
+++ b/app/src/main/java/emu/skyline/EmulationActivity.kt
@ -31,8 +31,8 @@ import emu.skyline.input.*
 import emu.skyline.loader.getRomFormat
 import emu.skyline.utils.ByteBufferSerializable
 import emu.skyline.utils.GpuDriverHelper
-import emu.skyline.utils.NativeSettings
-import emu.skyline.utils.PreferenceSettings
+import emu.skyline.settings.NativeSettings
+import emu.skyline.settings.PreferenceSettings
 import java.nio.ByteBuffer
 import java.nio.ByteOrder
 import java.util.concurrent.FutureTask
--- a/app/src/main/java/emu/skyline/MainActivity.kt
+++ b/app/src/main/java/emu/skyline/MainActivity.kt
@ -38,7 +38,8 @@ import emu.skyline.loader.LoaderResult
 import emu.skyline.loader.RomFormat
 import emu.skyline.provider.DocumentsProvider
 import emu.skyline.utils.GpuDriverHelper
-import emu.skyline.utils.PreferenceSettings
+import emu.skyline.settings.PreferenceSettings
+import emu.skyline.settings.SettingsActivity
 import emu.skyline.utils.WindowInsetsHelper
 import javax.inject.Inject
 import kotlin.math.ceil
--- a/app/src/main/java/emu/skyline/di/EntryPoints.kt
+++ b/app/src/main/java/emu/skyline/di/EntryPoints.kt
@ -11,7 +11,7 @@ import dagger.hilt.InstallIn
 import dagger.hilt.android.EntryPointAccessors
 import dagger.hilt.components.SingletonComponent
 import emu.skyline.input.InputManager
-import emu.skyline.utils.PreferenceSettings
+import emu.skyline.settings.PreferenceSettings

@EntryPoint
@InstallIn(SingletonComponent::class)
--- a/app/src/main/java/emu/skyline/input/ControllerActivity.kt
+++ b/app/src/main/java/emu/skyline/input/ControllerActivity.kt
@ -29,7 +29,7 @@ import emu.skyline.input.dialog.ButtonDialog
 import emu.skyline.input.dialog.RumbleDialog
 import emu.skyline.input.dialog.StickDialog
 import emu.skyline.input.onscreen.OnScreenEditActivity
-import emu.skyline.utils.PreferenceSettings
+import emu.skyline.settings.PreferenceSettings
 import emu.skyline.utils.WindowInsetsHelper
 import javax.inject.Inject

--- a/app/src/main/java/emu/skyline/input/InputHandler.kt
+++ b/app/src/main/java/emu/skyline/input/InputHandler.kt
@ -17,7 +17,7 @@ import android.view.OrientationEventListener
 import android.view.View
 import androidx.core.content.getSystemService
 import emu.skyline.utils.ByteBufferSerializable
-import emu.skyline.utils.PreferenceSettings
+import emu.skyline.settings.PreferenceSettings
 import emu.skyline.utils.u64
 import java.nio.ByteBuffer
 import java.nio.ByteOrder
--- a/app/src/main/java/emu/skyline/input/onscreen/OnScreenEditActivity.kt
+++ b/app/src/main/java/emu/skyline/input/onscreen/OnScreenEditActivity.kt
@ -15,7 +15,7 @@ import com.google.android.material.floatingactionbutton.FloatingActionButton
 import dagger.hilt.android.AndroidEntryPoint
 import emu.skyline.R
 import emu.skyline.databinding.OnScreenEditActivityBinding
-import emu.skyline.utils.PreferenceSettings
+import emu.skyline.settings.PreferenceSettings
 import javax.inject.Inject

@AndroidEntryPoint
--- a/app/src/main/java/emu/skyline/preference/DocumentsProviderPreference.kt
+++ b/app/src/main/java/emu/skyline/preference/DocumentsProviderPreference.kt
@ -14,7 +14,7 @@ import androidx.preference.Preference
 import androidx.preference.R
 import com.google.android.material.snackbar.Snackbar
 import emu.skyline.R as SkylineR
-import emu.skyline.SettingsActivity
+import emu.skyline.settings.SettingsActivity
 import emu.skyline.provider.DocumentsProvider

 class DocumentsProviderPreference @JvmOverloads constructor(context : Context, attrs : AttributeSet? = null, defStyleAttr : Int = R.attr.preferenceStyle) : Preference(context, attrs, defStyleAttr) {
--- a/app/src/main/java/emu/skyline/preference/GpuDriverActivity.kt
+++ b/app/src/main/java/emu/skyline/preference/GpuDriverActivity.kt
@ -25,7 +25,7 @@ import emu.skyline.adapter.SpacingItemDecoration
 import emu.skyline.databinding.GpuDriverActivityBinding
 import emu.skyline.utils.GpuDriverHelper
 import emu.skyline.utils.GpuDriverInstallResult
-import emu.skyline.utils.PreferenceSettings
+import emu.skyline.settings.PreferenceSettings
 import emu.skyline.utils.WindowInsetsHelper
 import kotlinx.coroutines.CoroutineScope
 import kotlinx.coroutines.Dispatchers
--- a/app/src/main/java/emu/skyline/preference/GpuDriverPreference.kt
+++ b/app/src/main/java/emu/skyline/preference/GpuDriverPreference.kt
@ -14,7 +14,7 @@ import androidx.preference.Preference
 import androidx.preference.Preference.SummaryProvider
 import androidx.preference.R
 import emu.skyline.utils.GpuDriverHelper
-import emu.skyline.utils.PreferenceSettings
+import emu.skyline.settings.PreferenceSettings
 import emu.skyline.R as SkylineR

 /**
--- a/app/src/main/java/emu/skyline/preference/KeyPickerPreference.kt
+++ b/app/src/main/java/emu/skyline/preference/KeyPickerPreference.kt
@ -14,7 +14,7 @@ import androidx.preference.Preference
 import com.google.android.material.snackbar.Snackbar
 import emu.skyline.KeyReader
 import emu.skyline.R
-import emu.skyline.SettingsActivity
+import emu.skyline.settings.SettingsActivity
 import emu.skyline.di.getSettings

 class KeyPickerPreference @JvmOverloads constructor(context : Context, attrs : AttributeSet? = null, defStyleAttr : Int = androidx.preference.R.attr.preferenceStyle) : Preference(context, attrs, defStyleAttr) {
--- a/app/src/main/java/emu/skyline/preference/LogLevelPreference.kt
+++ b/app/src/main/java/emu/skyline/preference/LogLevelPreference.kt
@ -8,7 +8,7 @@ package emu.skyline.preference
 import android.content.Context
 import android.util.AttributeSet
 import androidx.preference.R
-import emu.skyline.utils.NativeSettings
+import emu.skyline.settings.NativeSettings

 class LogLevelPreference @JvmOverloads constructor(context : Context, attrs : AttributeSet? = null, defStyleAttr : Int = R.attr.dialogPreferenceStyle) : IntegerListPreference(context, attrs, defStyleAttr) {
    init {
--- a/app/src/main/java/emu/skyline/settings/NativeSettings.kt
+++ b/app/src/main/java/emu/skyline/settings/NativeSettings.kt
@ -3,10 +3,11 @@
 * Copyright © 2022 Skyline Team and Contributors (https://github.com/skyline-emu/)
 */

-package emu.skyline.utils
+package emu.skyline.settings

 import android.content.Context
 import emu.skyline.BuildConfig
+import emu.skyline.utils.GpuDriverHelper

 /**
 * The settings that will be passed to libskyline when running and executable
--- a/app/src/main/java/emu/skyline/settings/PreferenceSettings.kt
+++ b/app/src/main/java/emu/skyline/settings/PreferenceSettings.kt
@ -3,14 +3,15 @@
 * Copyright © 2020 Skyline Team and Contributors (https://github.com/skyline-emu/)
 */

-package emu.skyline.utils
+package emu.skyline.settings

 import android.content.Context
 import android.content.pm.ActivityInfo
 import dagger.hilt.android.qualifiers.ApplicationContext
+import emu.skyline.R
+import emu.skyline.utils.sharedPreferences
 import javax.inject.Inject
 import javax.inject.Singleton
-import emu.skyline.R

@Singleton
 class PreferenceSettings @Inject constructor(@ApplicationContext private val context : Context) {
--- a/app/src/main/java/emu/skyline/settings/SettingsActivity.kt
+++ b/app/src/main/java/emu/skyline/settings/SettingsActivity.kt
@ -3,7 +3,7 @@
 * Copyright © 2020 Skyline Team and Contributors (https://github.com/skyline-emu/)
 */

-package emu.skyline
+package emu.skyline.settings

 import android.os.Bundle
 import android.view.*
@ -14,11 +14,12 @@ import androidx.preference.CheckBoxPreference
 import androidx.preference.Preference
 import androidx.preference.PreferenceCategory
 import androidx.preference.PreferenceFragmentCompat
+import emu.skyline.BuildConfig
+import emu.skyline.R
 import emu.skyline.databinding.SettingsActivityBinding
 import emu.skyline.preference.IntegerListPreference
 import emu.skyline.utils.GpuDriverHelper
 import emu.skyline.utils.WindowInsetsHelper
-import emu.skyline.utils.sharedPreferences

 class SettingsActivity : AppCompatActivity() {
    val binding by lazy { SettingsActivityBinding.inflate(layoutInflater) }