The-Homebrew-Cloud/skyline
2
0
Fork 0
mirror of https://github.com/skyline-emu/skyline.git synced 2024-11-23 13:39:19 +01:00
Code Issues Packages Projects Releases Wiki Activity

Log and flush inside KProcess::Kill

Browse Source 
We want to know when the `KProcess` is being killed and flushing log during it is important since it can often result in hangs due to joining not working correctly.
This commit is contained in:
PixelyIon 2022-10-22 17:17:04 +05:30
parent 597a6ff31d
commit c874907eb5
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/src/main/cpp/skyline/kernel/types/KProcess.cpp
View File

@ -26,6 +26,9 @@ namespace skyline::kernel::type {
} }
void KProcess::Kill(bool join, bool all, bool disableCreation) { void KProcess::Kill(bool join, bool all, bool disableCreation) {
Logger::Warn("Killing {}{}KProcess{}", join ? "and joining " : "", all ? "all threads in " : "HOS-0 in ", disableCreation ? " with new thread creation disabled" : "");
Logger::EmulationContext.Flush();
bool expected{false}; bool expected{false};
if (!join && !alreadyKilled.compare_exchange_strong(expected, true)) if (!join && !alreadyKilled.compare_exchange_strong(expected, true))
// If the process has already been killed and we don't want to wait for it to join then just instantly return rather than waiting on the mutex // If the process has already been killed and we don't want to wait for it to join then just instantly return rather than waiting on the mutex