The-Homebrew-Cloud/skyline
2
0
Fork 0
mirror of https://github.com/skyline-emu/skyline.git synced 2024-11-23 15:59:17 +01:00
Code Issues Packages Projects Releases Wiki Activity

Implement ContextLock Move-assignment operator

Browse Source 
In certain cases the move constructor may not suffice and the move assignment operator is required, this commit implements that and moves to using a pointer for storing the `resource` member rather than a reference as its semantics matched what we desired more and allowed for assignment of the `resource`.
This commit is contained in:
PixelyIon 2022-07-19 22:39:14 +05:30
parent 38d3ff4300
commit d2a34b5f7a
No known key found for this signature in database
GPG Key ID: 11BC6C3201BC2C05
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
app/src/main/cpp/skyline/gpu/tag_allocator.h
View File

@ -52,23 +52,30 @@ namespace skyline::gpu {
template<typename T> template<typename T>
class ContextLock { class ContextLock {
private: private:
T &resource; T *resource;
bool ownsLock; //!< If when this ContextLocked initially locked `resource`, it had never been locked for this context before bool ownsLock; //!< If when this ContextLocked initially locked `resource`, it had never been locked for this context before
public: public:
ContextLock(ContextTag tag, T &resource) : resource{resource}, ownsLock{resource.LockWithTag(tag)} {} ContextLock(ContextTag tag, T &resource) : resource{&resource}, ownsLock{resource.LockWithTag(tag)} {}
ContextLock(const ContextLock &) = delete; ContextLock(const ContextLock &) = delete;
ContextLock &operator=(const ContextLock &) = delete; ContextLock &operator=(const ContextLock &) = delete;
ContextLock(ContextLock &&other) noexcept : resource{other.resource}, ownsLock{other.ownsLock} { ContextLock(ContextLock &&other) : resource{other.resource}, ownsLock{other.ownsLock} {
other.ownsLock = false; other.ownsLock = false;
} }
ContextLock &operator=(ContextLock &&other) {
resource = other.resource;
ownsLock = other.ownsLock;
other.ownsLock = false;
return *this;
}
~ContextLock() { ~ContextLock() {
if (ownsLock) if (ownsLock)
resource.unlock(); resource->unlock();
} }
/** /**