mirror of
https://github.com/skyline-emu/skyline.git
synced 2024-11-04 23:35:12 +01:00
Address PR feedback
This commit is contained in:
parent
1b453c04ca
commit
d88b08d986
@ -35,7 +35,6 @@ namespace skyline::service::nvdrv::deserialisation {
|
||||
auto out{buffer.subspan(offset, bytes).template cast<RemoveSlotSizeSpan<ArgType>, std::dynamic_extent, true>()};
|
||||
offset += bytes;
|
||||
|
||||
|
||||
// Return a simple `span` as that will be the function argument type as opposed to `SlotSizeSpan`
|
||||
return out;
|
||||
}
|
||||
@ -48,10 +47,8 @@ namespace skyline::service::nvdrv::deserialisation {
|
||||
return std::tuple<Ts...>{std::forward<Ts>(ts)...};
|
||||
}
|
||||
|
||||
|
||||
template<typename Desc, typename ArgType, typename... ArgTypes>
|
||||
constexpr auto DecodeArgumentsImpl(span<u8, Desc::Size> buffer, size_t &offset, std::array<size_t, NumSaveSlots> &saveSlots) {
|
||||
|
||||
if constexpr (IsAutoSizeSpan<ArgType>::value) {
|
||||
// AutoSizeSpan needs to be the last argument
|
||||
static_assert(sizeof...(ArgTypes) == 0);
|
||||
|
@ -21,9 +21,11 @@ namespace skyline::soc::host1x {
|
||||
syncpoints.at(incrSyncpoint.index).Increment();
|
||||
break;
|
||||
}
|
||||
|
||||
case LoadSyncpointPayload32MethodId:
|
||||
syncpointPayload = argument;
|
||||
break;
|
||||
|
||||
case WaitSyncpoint32MethodId: {
|
||||
u32 syncpointId{static_cast<u8>(argument)};
|
||||
state.logger->Debug("Wait syncpoint: {}, thresh: {}", syncpointId, syncpointPayload);
|
||||
@ -31,6 +33,7 @@ namespace skyline::soc::host1x {
|
||||
syncpoints.at(syncpointId).Wait(syncpointPayload, std::chrono::steady_clock::duration::max());
|
||||
break;
|
||||
}
|
||||
|
||||
default:
|
||||
state.logger->Error("Unknown host1x class method called: 0x{:X}", method);
|
||||
break;
|
||||
|
@ -56,7 +56,7 @@ namespace skyline::soc::host1x {
|
||||
void Start();
|
||||
|
||||
/**
|
||||
* @brief Pushes a single gather into the fifo to be processed asynchronously
|
||||
* @brief Pushes a single gather into the FIFO to be processed asynchronously
|
||||
*/
|
||||
void Push(span<u32> gather);
|
||||
};
|
||||
|
Loading…
Reference in New Issue
Block a user