The-Homebrew-Cloud/skyline
2
0
Fork 0
mirror of https://github.com/skyline-emu/skyline.git synced 2024-12-23 12:21:51 +01:00
Code Issues Packages Projects Releases Wiki Activity

Flush emulation logs after exceptions

Browse Source 
A lot of logs are incomplete due to being unable to flush inside the signal handler, now we flush after any exceptions so that there is a guarantee of any exceptions being logged as this is crucial for proper debugging.
This commit is contained in:
PixelyIon 2022-04-10 13:19:50 +05:30
parent 62ba180550
commit ea00f1bb82
4 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/src/main/cpp/skyline/kernel/types/KThread.cpp
View File

@ -177,6 +177,7 @@ namespace skyline::kernel::type {
__builtin_unreachable();
} catch (const std::exception &e) {
Logger::Error(e.what());
Logger::EmulationContext.Flush();
if (id) {
signal::BlockSignal({SIGINT});
state.process->Kill(false);
@ -186,6 +187,7 @@ namespace skyline::kernel::type {
} catch (const signal::SignalException &e) {
if (e.signal != SIGINT) {
Logger::Error(e.what());
Logger::EmulationContext.Flush();
if (id) {
signal::BlockSignal({SIGINT});
state.process->Kill(false);

7
app/src/main/cpp/skyline/nce.cpp
View File

@ -41,10 +41,14 @@ namespace skyline::nce {
} catch (const signal::SignalException &e) {
if (e.signal != SIGINT) {
Logger::ErrorNoPrefix("{} (SVC: {})\nStack Trace:{}", e.what(), svc.name, state.loader->GetStackTrace(e.frames));
Logger::EmulationContext.Flush();
if (state.thread->id) {
signal::BlockSignal({SIGINT});
state.process->Kill(false);
}
} else {
Logger::EmulationContext.Flush();
}
abi::__cxa_end_catch(); // We call this prior to the longjmp to cause the exception object to be destroyed
std::longjmp(state.thread->originalCtx, true);
@ -60,6 +64,8 @@ namespace skyline::nce {
else
Logger::ErrorNoPrefix("{} (SVC: 0x{:X})\nStack Trace:{}", e.what(), svcId, state.loader->GetStackTrace());
Logger::EmulationContext.Flush();
if (state.thread->id) {
signal::BlockSignal({SIGINT});
state.process->Kill(false);
@ -94,6 +100,7 @@ namespace skyline::nce {
cpuContext += fmt::format("\n X{:<2}: 0x{:<16X} X{:<2}: 0x{:X}", index, mctx.regs[index], index + 1, mctx.regs[index + 1]);
Logger::Error("Thread #{} has crashed due to signal: {}\nStack Trace:{}\nCPU Context:{}", state.thread->id, strsignal(signal), trace, cpuContext);
Logger::EmulationContext.Flush();
if (state.thread->id) {
signal::BlockSignal({SIGINT});

2
app/src/main/cpp/skyline/soc/gm20b/gpfifo.cpp
View File

@ -346,11 +346,13 @@ namespace skyline::soc::gm20b {
} catch (const signal::SignalException &e) {
if (e.signal != SIGINT) {
Logger::Error("{}\nStack Trace:{}", e.what(), state.loader->GetStackTrace(e.frames));
Logger::EmulationContext.Flush();
signal::BlockSignal({SIGINT});
state.process->Kill(false);
}
} catch (const std::exception &e) {
Logger::Error(e.what());
Logger::EmulationContext.Flush();
signal::BlockSignal({SIGINT});
state.process->Kill(false);
}

2
app/src/main/cpp/skyline/soc/host1x/command_fifo.cpp
View File

@ -126,11 +126,13 @@ namespace skyline::soc::host1x {
} catch (const signal::SignalException &e) {
if (e.signal != SIGINT) {
Logger::Error("{}\nStack Trace:{}", e.what(), state.loader->GetStackTrace(e.frames));
Logger::EmulationContext.Flush();
signal::BlockSignal({SIGINT});
state.process->Kill(false);
}
} catch (const std::exception &e) {
Logger::Error(e.what());
Logger::EmulationContext.Flush();
signal::BlockSignal({SIGINT});
state.process->Kill(false);
}