The-Homebrew-Cloud/skyline
2
0
Fork 0
mirror of https://github.com/skyline-emu/skyline.git synced 2024-06-01 16:28:47 +02:00
Code Issues Packages Projects Releases Wiki Activity

Validate NpadId for ActivateVibrationDevice

Browse Source
This commit is contained in:
Dima 2022-11-22 14:53:50 +03:00 committed by Billy Laws
parent 4bdd033354
commit ebcbc5b05b
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/src/main/cpp/skyline/input/npad.h
View File

@ -83,7 +83,7 @@ namespace skyline::input {
/**
* @brief Checks if the NpadId is valid
*/
bool IsNpadIdValid(NpadId id) {
static bool IsNpadIdValid(NpadId id) {
switch (id) {
case NpadId::Player1:
case NpadId::Player2:

5
app/src/main/cpp/skyline/services/hid/IActiveVibrationDeviceList.cpp
View File

@ -12,8 +12,9 @@ namespace skyline::service::hid {
Result IActiveVibrationDeviceList::ActivateVibrationDevice(type::KSession &session, ipc::IpcRequest &request, ipc::IpcResponse &response) {
auto handle{request.Pop<NpadDeviceHandle>()};
if (!handle.isRight)
state.input->npad.at(handle.id).vibrationRight = NpadVibrationValue{};
if (NpadManager::IsNpadIdValid(handle.id))
if (!handle.isRight)
state.input->npad.at(handle.id).vibrationRight = NpadVibrationValue{};
return {};
}