The-Homebrew-Cloud/skyline
2
0
Fork 0
mirror of https://github.com/skyline-emu/skyline.git synced 2024-12-24 17:21:51 +01:00
Code Issues Packages Projects Releases Wiki Activity

Calculate renderArea from min(attachments.dimensions...)

Browse Source 
Vulkan doesn't support a renderArea larger than that of the smallest attachment
This commit is contained in:
Billy Laws 2022-07-31 14:29:44 +01:00
parent 9ea658d0ed
commit eeb86a4f8a
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
app/src/main/cpp/skyline/gpu/interconnect/graphics_context.h
View File

@ -2971,6 +2971,13 @@ namespace skyline::gpu::interconnect {
executor.AttachDependency(drawStorage); executor.AttachDependency(drawStorage);
} }
vk::Rect2D renderArea{depthRenderTargetView ? vk::Rect2D{.extent = depthRenderTargetView->texture->dimensions} : vk::Rect2D{.extent = {std::numeric_limits<u32>::max(), std::numeric_limits<u32>::max()}}};
for (auto &colorRt : activeColorRenderTargets) {
renderArea.extent.width = std::min(renderArea.extent.width, colorRt->texture->dimensions.width);
renderArea.extent.height = std::min(renderArea.extent.height, colorRt->texture->dimensions.height);
}
// Submit Draw // Submit Draw
executor.AddSubpass([=, drawStorage = std::move(drawStorage), pipelineLayout = compiledPipeline.pipelineLayout, pipeline = compiledPipeline.pipeline](vk::raii::CommandBuffer &commandBuffer, const std::shared_ptr<FenceCycle> &cycle, GPU &, vk::RenderPass renderPass, u32 subpassIndex) mutable { executor.AddSubpass([=, drawStorage = std::move(drawStorage), pipelineLayout = compiledPipeline.pipelineLayout, pipeline = compiledPipeline.pipeline](vk::raii::CommandBuffer &commandBuffer, const std::shared_ptr<FenceCycle> &cycle, GPU &, vk::RenderPass renderPass, u32 subpassIndex) mutable {
auto &vertexBufferHandles{boundVertexBuffers->handles}; auto &vertexBufferHandles{boundVertexBuffers->handles};
@ -3003,9 +3010,7 @@ namespace skyline::gpu::interconnect {
} else { } else {
commandBuffer.draw(count, instanceCount, first, 0); commandBuffer.draw(count, instanceCount, first, 0);
} }
}, vk::Rect2D{ }, renderArea, {}, activeColorRenderTargets, depthRenderTargetView, !gpu.traits.quirks.relaxedRenderPassCompatibility);
.extent = activeColorRenderTargets.empty() ? depthRenderTarget.guest.dimensions : activeColorRenderTargets.front()->texture->dimensions,
}, {}, activeColorRenderTargets, depthRenderTargetView, !gpu.traits.quirks.relaxedRenderPassCompatibility);
} }
void Draw(u32 vertexCount, u32 firstVertex, u32 instanceCount) { void Draw(u32 vertexCount, u32 firstVertex, u32 instanceCount) {