improvements to optionbrowser

source/ngc/gui/gui.h

@@ -800,11 +800,13 @@ class GuiOptionBrowser : public GuiElement
 		void ResetState();
 		void SetFocus(int f);
 		void Draw();
+		void TriggerUpdate();
 		void Update(GuiTrigger * t);
 		GuiText * optionVal[PAGESIZE];
 	protected:
 		int selectedItem;
 		int listOffset;
+		bool listChanged;
 
 		OptionList * options;
 		int optionIndex[PAGESIZE];

source/ngc/gui/gui_optionbrowser.cpp

@@ -20,6 +20,7 @@ GuiOptionBrowser::GuiOptionBrowser(int w, int h, OptionList * l)
 	options = l;
 	selectable = true;
 	listOffset = this->FindMenuItem(-1, 1);
+	listChanged = true; // trigger an initial list update
 	selectedItem = 0;
 	focus = 0; // allow focus
 
@@ -76,7 +77,7 @@ GuiOptionBrowser::GuiOptionBrowser(int w, int h, OptionList * l)
 
 	for(int i=0; i<PAGESIZE; i++)
 	{
-		optionTxt[i] = new GuiText(options->name[i], 22, (GXColor){0, 0, 0, 0xff});
+		optionTxt[i] = new GuiText(NULL, 22, (GXColor){0, 0, 0, 0xff});
 		optionTxt[i]->SetAlignment(ALIGN_LEFT, ALIGN_MIDDLE);
 		optionTxt[i]->SetPosition(8,0);
 
@@ -228,6 +229,11 @@ void GuiOptionBrowser::Draw()
 	this->UpdateEffects();
 }
 
+void GuiOptionBrowser::TriggerUpdate()
+{
+	listChanged = true;
+}
+
 void GuiOptionBrowser::Update(GuiTrigger * t)
 {
 	if(state == STATE_DISABLED || !t)
@@ -240,6 +246,9 @@ void GuiOptionBrowser::Update(GuiTrigger * t)
 
 	next = listOffset;
 
+	if(listChanged)
+	{
+		listChanged = false;
 		for(int i=0; i<PAGESIZE; i++)
 		{
 			if(next >= 0)
@@ -260,7 +269,11 @@ void GuiOptionBrowser::Update(GuiTrigger * t)
 				optionBtn[i]->SetVisible(false);
 				optionBtn[i]->SetState(STATE_DISABLED);
 			}
+		}
+	}
 
+	for(int i=0; i<PAGESIZE; i++)
+	{
 		if(i != selectedItem && optionBtn[i]->GetState() == STATE_SELECTED)
 			optionBtn[i]->ResetState();
 		else if(focus && i == selectedItem && optionBtn[i]->GetState() == STATE_DEFAULT)
@@ -292,6 +305,7 @@ void GuiOptionBrowser::Update(GuiTrigger * t)
 			{
 				// move list down by 1
 				listOffset = this->FindMenuItem(listOffset, 1);
+				listChanged = true;
 			}
 			else if(optionBtn[selectedItem+1]->IsVisible())
 			{
@@ -312,6 +326,7 @@ void GuiOptionBrowser::Update(GuiTrigger * t)
 			{
 				// move list up by 1
 				listOffset = prev;
+				listChanged = true;
 			}
 			else
 			{

source/ngc/menu.cpp

@@ -2013,13 +2013,13 @@ static int MenuGameCheats()
 	OptionList options;
 
 	for(i=0; i < Cheat.num_cheats; i++)
+	{
 		sprintf (options.name[i], "%s", Cheat.c[i].name);
+		sprintf (options.value[i], "%s", Cheat.c[i].enabled == true ? "On" : "Off");
+	}
 
 	options.length = i;
 
-	for(i=0; i < options.length; i++)
-		options.value[i][0] = 0;
-
 	GuiText titleTxt("Game Settings - Cheats", 28, (GXColor){255, 255, 255, 255});
 	titleTxt.SetAlignment(ALIGN_LEFT, ALIGN_TOP);
 	titleTxt.SetPosition(50,50);
@@ -2065,15 +2065,17 @@ static int MenuGameCheats()
 	{
 		usleep(THREAD_SLEEP);
 
-		for(i=0; i < Cheat.num_cheats; i++)
-			sprintf (options.value[i], "%s", Cheat.c[i].enabled == true ? "On" : "Off");
-
 		ret = optionBrowser.GetClickedOption();
 
+		if(ret >= 0)
+		{
 			if(Cheat.c[ret].enabled)
 				S9xDisableCheat(ret);
 			else
 				S9xEnableCheat(ret);
+			sprintf (options.value[ret], "%s", Cheat.c[ret].enabled == true ? "On" : "Off");
+			optionBrowser.TriggerUpdate();
+		}
 
 		if(backBtn.GetState() == STATE_CLICKED)
 		{
@@ -2548,6 +2550,7 @@ static int MenuSettingsMappingsMap()
 {
 	int menu = MENU_NONE;
 	int ret,i,j;
+	bool firstRun = true;
 	OptionList options;
 
 	char menuTitle[100];
@@ -2667,6 +2670,18 @@ static int MenuSettingsMappingsMap()
 	{
 		usleep(THREAD_SLEEP);
 
+		ret = optionBrowser.GetClickedOption();
+
+		if(ret >= 0)
+		{
+			// get a button selection from user
+			btnmap[mapMenuCtrlSNES][mapMenuCtrl][ret] = ButtonMappingWindow();
+		}
+
+		if(ret >= 0 || firstRun)
+		{
+			firstRun = false;
+
 			for(i=0; i < options.length; i++)
 			{
 				for(j=0; j < ctrlr_def[mapMenuCtrl].num_btns; j++)
@@ -2684,13 +2699,7 @@ static int MenuSettingsMappingsMap()
 					}
 				}
 			}
-
+			optionBrowser.TriggerUpdate();
-		ret = optionBrowser.GetClickedOption();
-
-		if(ret >= 0)
-		{
-			// get a button selection from user
-			btnmap[mapMenuCtrlSNES][mapMenuCtrl][ret] = ButtonMappingWindow();
 		}
 
 		if(backBtn.GetState() == STATE_CLICKED)
@@ -2708,7 +2717,10 @@ static int MenuSettingsMappingsMap()
 				"No");
 
 			if(choice == 1)
+			{
 				ResetControls(mapMenuCtrlSNES, mapMenuCtrl);
+				optionBrowser.TriggerUpdate();
+			}
 		}
 	}
 	HaltGui();
@@ -2931,6 +2943,7 @@ static int MenuSettingsVideo()
 	int menu = MENU_NONE;
 	int ret;
 	int i = 0;
+	bool firstRun = true;
 	OptionList options;
 
 	sprintf(options.name[i++], "Rendering");
@@ -2990,6 +3003,44 @@ static int MenuSettingsVideo()
 	{
 		usleep(THREAD_SLEEP);
 
+		ret = optionBrowser.GetClickedOption();
+
+		switch (ret)
+		{
+			case 0:
+				GCSettings.render++;
+				if (GCSettings.render > 2)
+					GCSettings.render = 0;
+				break;
+
+			case 1:
+				GCSettings.widescreen ^= 1;
+				break;
+
+			case 2:
+				GCSettings.FilterMethod++;
+				if (GCSettings.FilterMethod >= NUM_FILTERS)
+					GCSettings.FilterMethod = 0;
+				break;
+
+			case 3:
+				ScreenZoomWindow();
+				break;
+
+			case 4:
+				ScreenPositionWindow();
+				break;
+			case 5:
+				GCSettings.videomode++;
+				if(GCSettings.videomode > 4)
+					GCSettings.videomode = 0;
+				break;
+		}
+
+		if(ret >= 0 || firstRun)
+		{
+			firstRun = false;
+
 			// don't allow original render mode if progressive video mode detected
 			if (GCSettings.render==0 && progressive)
 				GCSettings.render++;
@@ -3025,39 +3076,7 @@ static int MenuSettingsVideo()
 				case 4:
 					sprintf (options.value[5], "PAL (60Hz)"); break;
 			}
-
+			optionBrowser.TriggerUpdate();
-		ret = optionBrowser.GetClickedOption();
-
-		switch (ret)
-		{
-			case 0:
-				GCSettings.render++;
-				if (GCSettings.render > 2)
-					GCSettings.render = 0;
-				break;
-
-			case 1:
-				GCSettings.widescreen ^= 1;
-				break;
-
-			case 2:
-				GCSettings.FilterMethod++;
-				if (GCSettings.FilterMethod >= NUM_FILTERS)
-					GCSettings.FilterMethod = 0;
-				break;
-
-			case 3:
-				ScreenZoomWindow();
-				break;
-
-			case 4:
-				ScreenPositionWindow();
-				break;
-			case 5:
-				GCSettings.videomode++;
-				if(GCSettings.videomode > 4)
-					GCSettings.videomode = 0;
-				break;
 		}
 
 		if(backBtn.GetState() == STATE_CLICKED)
@@ -3249,6 +3268,7 @@ static int MenuSettingsFile()
 	int menu = MENU_NONE;
 	int ret;
 	int i = 0;
+	bool firstRun = true;
 	OptionList options;
 	sprintf(options.name[i++], "Load Device");
 	sprintf(options.name[i++], "Save Device");
@@ -3309,6 +3329,51 @@ static int MenuSettingsFile()
 	{
 		usleep(THREAD_SLEEP);
 
+		ret = optionBrowser.GetClickedOption();
+
+		switch (ret)
+		{
+			case 0:
+				GCSettings.LoadMethod++;
+				break;
+
+			case 1:
+				GCSettings.SaveMethod++;
+				break;
+
+			case 2:
+				OnScreenKeyboard(GCSettings.LoadFolder, MAXPATHLEN);
+				break;
+
+			case 3:
+				OnScreenKeyboard(GCSettings.SaveFolder, MAXPATHLEN);
+				break;
+
+			case 4:
+				OnScreenKeyboard(GCSettings.CheatFolder, MAXPATHLEN);
+				break;
+
+			case 5:
+				GCSettings.AutoLoad++;
+				if (GCSettings.AutoLoad > 2)
+					GCSettings.AutoLoad = 0;
+				break;
+
+			case 6:
+				GCSettings.AutoSave++;
+				if (GCSettings.AutoSave > 3)
+					GCSettings.AutoSave = 0;
+				break;
+
+			case 7:
+				GCSettings.VerifySaves ^= 1;
+				break;
+		}
+
+		if(ret >= 0 || firstRun)
+		{
+			firstRun = false;
+
 			// some load/save methods are not implemented - here's where we skip them
 			// they need to be skipped in the order they were enumerated in snes9xGX.h
 
@@ -3375,45 +3440,7 @@ static int MenuSettingsFile()
 
 			sprintf (options.value[7], "%s", GCSettings.VerifySaves == true ? "On" : "Off");
 
-		ret = optionBrowser.GetClickedOption();
+			optionBrowser.TriggerUpdate();
-
-		switch (ret)
-		{
-			case 0:
-				GCSettings.LoadMethod++;
-				break;
-
-			case 1:
-				GCSettings.SaveMethod++;
-				break;
-
-			case 2:
-				OnScreenKeyboard(GCSettings.LoadFolder, MAXPATHLEN);
-				break;
-
-			case 3:
-				OnScreenKeyboard(GCSettings.SaveFolder, MAXPATHLEN);
-				break;
-
-			case 4:
-				OnScreenKeyboard(GCSettings.CheatFolder, MAXPATHLEN);
-				break;
-
-			case 5:
-				GCSettings.AutoLoad++;
-				if (GCSettings.AutoLoad > 2)
-					GCSettings.AutoLoad = 0;
-				break;
-
-			case 6:
-				GCSettings.AutoSave++;
-				if (GCSettings.AutoSave > 3)
-					GCSettings.AutoSave = 0;
-				break;
-
-			case 7:
-				GCSettings.VerifySaves ^= 1;
-				break;
 		}
 
 		if(backBtn.GetState() == STATE_CLICKED)
@@ -3437,6 +3464,7 @@ static int MenuSettingsMenu()
 	int menu = MENU_NONE;
 	int ret;
 	int i = 0;
+	bool firstRun = true;
 	OptionList options;
 
 	sprintf(options.name[i++], "Exit Action");
@@ -3494,6 +3522,38 @@ static int MenuSettingsMenu()
 	{
 		usleep(THREAD_SLEEP);
 
+		ret = optionBrowser.GetClickedOption();
+
+		switch (ret)
+		{
+			case 0:
+				GCSettings.ExitAction++;
+				if(GCSettings.ExitAction > 3)
+					GCSettings.ExitAction = 0;
+				break;
+			case 1:
+				GCSettings.WiimoteOrientation ^= 1;
+				break;
+			case 2:
+				GCSettings.MusicVolume += 10;
+				if(GCSettings.MusicVolume > 100)
+					GCSettings.MusicVolume = 0;
+				bgMusic->SetVolume(GCSettings.MusicVolume);
+				break;
+			case 3:
+				GCSettings.SFXVolume += 10;
+				if(GCSettings.SFXVolume > 100)
+					GCSettings.SFXVolume = 0;
+				break;
+			case 4:
+				GCSettings.Rumble ^= 1;
+				break;
+		}
+
+		if(ret >= 0 || firstRun)
+		{
+			firstRun = false;
+
 			#ifdef HW_RVL
 			if (GCSettings.ExitAction == 1)
 				sprintf (options.value[0], "Return to Wii Menu");
@@ -3537,32 +3597,7 @@ static int MenuSettingsMenu()
 			else
 				sprintf (options.value[4], "Disabled");
 
-		ret = optionBrowser.GetClickedOption();
+			optionBrowser.TriggerUpdate();
-
-		switch (ret)
-		{
-			case 0:
-				GCSettings.ExitAction++;
-				if(GCSettings.ExitAction > 3)
-					GCSettings.ExitAction = 0;
-				break;
-			case 1:
-				GCSettings.WiimoteOrientation ^= 1;
-				break;
-			case 2:
-				GCSettings.MusicVolume += 10;
-				if(GCSettings.MusicVolume > 100)
-					GCSettings.MusicVolume = 0;
-				bgMusic->SetVolume(GCSettings.MusicVolume);
-				break;
-			case 3:
-				GCSettings.SFXVolume += 10;
-				if(GCSettings.SFXVolume > 100)
-					GCSettings.SFXVolume = 0;
-				break;
-			case 4:
-				GCSettings.Rumble ^= 1;
-				break;
 		}
 
 		if(backBtn.GetState() == STATE_CLICKED)
@@ -3587,6 +3622,7 @@ static int MenuSettingsNetwork()
 #ifdef HW_RVL
 	int ret;
 	int i = 0;
+	bool firstRun = true;
 	OptionList options;
 	sprintf(options.name[i++], "SMB Share IP");
 	sprintf(options.name[i++], "SMB Share Name");
@@ -3642,11 +3678,6 @@ static int MenuSettingsNetwork()
 	{
 		usleep(THREAD_SLEEP);
 
-		strncpy (options.value[0], GCSettings.smbip, 15);
-		strncpy (options.value[1], GCSettings.smbshare, 19);
-		strncpy (options.value[2], GCSettings.smbuser, 19);
-		strncpy (options.value[3], GCSettings.smbpwd, 19);
-
 		ret = optionBrowser.GetClickedOption();
 
 		switch (ret)
@@ -3668,6 +3699,16 @@ static int MenuSettingsNetwork()
 				break;
 		}
 
+		if(ret >= 0 || firstRun)
+		{
+			firstRun = false;
+			strncpy (options.value[0], GCSettings.smbip, 15);
+			strncpy (options.value[1], GCSettings.smbshare, 19);
+			strncpy (options.value[2], GCSettings.smbuser, 19);
+			strncpy (options.value[3], GCSettings.smbpwd, 19);
+			optionBrowser.TriggerUpdate();
+		}
+
 		if(backBtn.GetState() == STATE_CLICKED)
 		{
 			menu = MENU_SETTINGS;