* use ++i instead of i++ for iterators

This commit is contained in:
giantpune 2011-05-18 17:24:51 +00:00
parent d0ca7c0f15
commit a27c48058c
3 changed files with 8 additions and 11 deletions

View File

@ -37,7 +37,7 @@ bool NandBin::SetPath( const QString &path )
f.setFileName( path ); f.setFileName( path );
bool ret = ( f.exists() && bool ret = ( f.exists() &&
#ifdef NAND_BIN_CAN_WRITE #ifdef NAND_BIN_CAN_WRITE
f.open( QIODevice::ReadWrite ) ); f.open( QIODevice::ReadWrite ) );
#else #else
f.open( QIODevice::ReadOnly ) ); f.open( QIODevice::ReadOnly ) );
#endif #endif
@ -237,8 +237,6 @@ bool NandBin::ExtractToDir( QTreeWidgetItem *item, const QString &path )
return false; return false;
} }
return ExtractFST( entry, path, true );//dont bother extracting this item's siblings return ExtractFST( entry, path, true );//dont bother extracting this item's siblings
return true;
} }
QTreeWidgetItem *NandBin::CreateItem( QTreeWidgetItem *parent, const QString &name, quint32 size, quint16 entry, quint32 uid, quint32 gid, quint32 x3, quint8 attr, quint8 wtf) QTreeWidgetItem *NandBin::CreateItem( QTreeWidgetItem *parent, const QString &name, quint32 size, quint16 entry, quint32 uid, quint32 gid, quint32 x3, quint8 attr, quint8 wtf)

View File

@ -107,9 +107,8 @@ void NusDownloader::StartNextJob()
{ {
tmdJob.name = "tmd"; tmdJob.name = "tmd";
dlJob = tmdJob; dlJob = tmdJob;
QTimer::singleShot( 500, this, SLOT( StartDownload() ) ); QTimer::singleShot( 50, this, SLOT( StartDownload() ) );
} }
} }
//tries to read data for the job from the PC //tries to read data for the job from the PC
@ -589,7 +588,7 @@ bool NusDownloader::GetUpdate( const QString & upd, bool decrypt )
while( i != titles.end() ) while( i != titles.end() )
{ {
Get( i.key(), decrypt, i.value() ); Get( i.key(), decrypt, i.value() );
i++; ++i;
} }
return true; return true;
} }

View File

@ -115,7 +115,7 @@ bool U8::RenameEntry( const QString &path, const QString &newName )
return ReplaceEntry( i.key(),i.value().GetData() ); return ReplaceEntry( i.key(),i.value().GetData() );
//NOTE - after replacing the entry, "i" is no longer valid. keep that in mind when changing this code. its a bitch to track down this bug //NOTE - after replacing the entry, "i" is no longer valid. keep that in mind when changing this code. its a bitch to track down this bug
} }
i++; ++i;
} }
//make sure the new filename doesnt already exist //make sure the new filename doesnt already exist
QString parentPath = path; QString parentPath = path;
@ -294,7 +294,7 @@ bool U8::ReplaceEntry( const QString &path, const QByteArray &nba, bool autoComp
return ReplaceEntry( chPath, ch.GetData() ); return ReplaceEntry( chPath, ch.GetData() );
//NOTE - after replacing the entry, "i" is no longer valid. keep that in mind when changing this code. its a bitch to track down this bug //NOTE - after replacing the entry, "i" is no longer valid. keep that in mind when changing this code. its a bitch to track down this bug
} }
i++; ++i;
} }
//find the entry to replace //find the entry to replace
int entryToReplace = FindEntry( path ); int entryToReplace = FindEntry( path );
@ -397,7 +397,7 @@ bool U8::RemoveEntry( const QString &path )
return ReplaceEntry( chPath, ch.GetData() );//insert the new nested archive in this one return ReplaceEntry( chPath, ch.GetData() );//insert the new nested archive in this one
//NOTE - after replacing the entry, "i" is no longer valid. keep that in mind when changing this code. its a bitch to track down this bug //NOTE - after replacing the entry, "i" is no longer valid. keep that in mind when changing this code. its a bitch to track down this bug
} }
i++; ++i;
} }
//find the entry to delete //find the entry to delete
int entryToDelete = FindEntry( path ); int entryToDelete = FindEntry( path );
@ -617,7 +617,7 @@ int U8::AddEntry( const QString &path, int type, const QByteArray &newData )
//qDebug() << "done replacing the child entry in this archive, finding the index to return (" << thisPath << ")"; //qDebug() << "done replacing the child entry in this archive, finding the index to return (" << thisPath << ")";
return FindEntry( thisPath );//just return the index of the nested archive return FindEntry( thisPath );//just return the index of the nested archive
} }
i++; ++i;
} }
//make sure this path doesnt already exist //make sure this path doesnt already exist
@ -1124,7 +1124,7 @@ const QByteArray U8::GetData( const QString &str, bool onlyPayload )
subPath.remove( 0, i.key().size() + 1 );//remove the path of the archive itself + the slash subPath.remove( 0, i.key().size() + 1 );//remove the path of the archive itself + the slash
return i.value().GetData( subPath, onlyPayload ); return i.value().GetData( subPath, onlyPayload );
} }
i++; ++i;
} }
int index = FindEntry( str ); int index = FindEntry( str );
if( index < 0 ) if( index < 0 )