mirror of
https://github.com/martravi/wiiqt.git
synced 2024-11-25 02:26:56 +01:00
* use const reference in foreach() also
This commit is contained in:
parent
3ee828284a
commit
d0ca7c0f15
@ -13,7 +13,7 @@ SettingTxtDialog::SettingTxtDialog( QWidget *parent, const QByteArray &old, qint
|
||||
QString str( copy );
|
||||
str.replace( "\r\n", "\n" );//maybe not needed to do this in 2 steps, but there may be some reason the file only uses "\n", so do it this way to be safe
|
||||
QStringList parts = str.split( "\n", QString::SkipEmptyParts );
|
||||
foreach( QString part, parts )
|
||||
foreach( const QString &part, parts )
|
||||
{
|
||||
QString p = part;
|
||||
if( part.startsWith( "AREA=" ) )
|
||||
|
@ -230,7 +230,7 @@ const QByteArray DataFromSave( const SaveGame &save, const QString &name )
|
||||
quint32 SaveItemSize( const SaveGame &save )
|
||||
{
|
||||
quint32 ret = 0;
|
||||
foreach( QByteArray ba, save.data )
|
||||
foreach( const QByteArray &ba, save.data )
|
||||
ret += ba.size();
|
||||
return ret;
|
||||
}
|
||||
|
@ -896,7 +896,7 @@ void U8::CreateEntryList()
|
||||
if( child.IsOK() )
|
||||
{
|
||||
nestedU8s.insert( path, child );
|
||||
foreach( QString chPath, child.Entries() )
|
||||
foreach( const QString &chPath, child.Entries() )
|
||||
{
|
||||
QString newPath = path + "/" + chPath;
|
||||
paths << newPath;
|
||||
|
@ -111,7 +111,7 @@ void PrintColoredString( const char *msg, int highlite )
|
||||
{
|
||||
QString str( msg );
|
||||
QStringList list = str.split( "\n", QString::SkipEmptyParts );
|
||||
foreach( QString s, list )
|
||||
foreach( const QString &s, list )
|
||||
{
|
||||
QString m = s;
|
||||
QString m2 = s.trimmed();
|
||||
@ -183,7 +183,7 @@ void Usage()
|
||||
qDebug() << "";
|
||||
qDebug() << " -all does all of the above";
|
||||
qDebug() << "";
|
||||
qDebug() << " -v increase verbosity";
|
||||
qDebug() << " -v increase verbosity ( can be used more than once )";
|
||||
qDebug() << "";
|
||||
qDebug() << " -continue try to keep going as fas as possible on errors that should be fatal";
|
||||
qDebug() << "";
|
||||
@ -754,12 +754,7 @@ bool CheckTitleIntegrity( quint64 tid )
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
}
|
||||
|
||||
|
||||
|
||||
}
|
||||
|
||||
if( upper == 0x10005 || upper == 0x10007 ) //dont try to verify all the contents of DLC, it will just find a bunch of missing contents and bitch about them
|
||||
@ -1197,7 +1192,7 @@ void CheckSettingTxt()
|
||||
QString str( settingTxt );
|
||||
str.replace( "\r\n", "\n" );//maybe not needed to do this in 2 steps, but there may be some reason the file only uses "\n", so do it this way to be safe
|
||||
QStringList parts = str.split( "\n", QString::SkipEmptyParts );
|
||||
foreach( QString part, parts )
|
||||
foreach( const QString &part, parts )
|
||||
{
|
||||
if( part.startsWith( "AREA=" ) )
|
||||
{
|
||||
|
@ -329,7 +329,7 @@ void MainWindow::on_actionImportWad_triggered()
|
||||
|
||||
if( fns.isEmpty() )
|
||||
return;
|
||||
foreach( QString fn, fns )
|
||||
foreach( const QString &fn, fns )
|
||||
{
|
||||
QByteArray data = ReadFile( fn );
|
||||
if( data.isEmpty() )
|
||||
|
@ -229,7 +229,7 @@ void NewNandBin::on_pushButton_badBlockFile_clicked()
|
||||
|
||||
str.replace( "\r\n", "\n" );
|
||||
QStringList lines = str.split( "\n", QString::SkipEmptyParts );
|
||||
foreach( QString line, lines )
|
||||
foreach( const QString &line, lines )
|
||||
{
|
||||
if( line.size() > 5 )
|
||||
continue;
|
||||
|
Loading…
Reference in New Issue
Block a user