Mirrors
/
cartreader
mirror of https://github.com/sanni/cartreader.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fixed (added) missing FS() macro on some FSTRING constants 

This was causing two symptoms/bugs:
* OSCR_LOG.txt was being spammed with random data.
* The size of OSCR_LOG.txt would get so big that copying the log would take a long time, possibly minutes. Oftentimes this caused the display to appear to hang after searching for the CRC (after "->") but before displaying the result.

If using the global log and a version of master since e61ac414d8 you should delete OSCR_LOG.txt from your SD card as it will likely be very large and continue to cause dumping to be slow.
This commit is contained in:
Ancyker 2024-05-07 17:16:51 -04:00
parent 8bd6d7dfdc
commit 40238b18a1
No known key found for this signature in database
GPG Key ID: 841A6B28CD25A744
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Cart_Reader/Cart_Reader.ino
View File

@ -2566,7 +2566,7 @@ void display_Clear() {
display.setCursor(0, 8);
#endif
#ifdef ENABLE_GLOBAL_LOG
if (!dont_log && loggingEnabled) myLog.println(FSTRING_EMPTY);
if (!dont_log && loggingEnabled) myLog.println(FS(FSTRING_EMPTY));
#endif
}

2
Cart_Reader/N64.ino
View File

@ -3057,7 +3057,7 @@ void savesummary_N64(boolean checkfound, char crcStr[9], unsigned long timeElaps
myFile.print(F("Time\t: "));
myFile.println(timeElapsed);
myFile.println(FSTRING_SPACE);
myFile.println(FS(FSTRING_SPACE));
// Close the file:
myFile.close();