The-Homebrew-Cloud/Genesis-Plus-GX
2
0
Fork 0
mirror of https://github.com/ekeeke/Genesis-Plus-GX.git synced 2024-12-25 10:41:49 +01:00
Code Issues Packages Projects Releases Wiki Activity

[Core/CD] improved Sub-CPU BUSREQ status accuracy

Browse Source
This commit is contained in:
ekeeke 2023-08-25 16:47:01 +02:00
parent ad706045d3
commit 5a3e18f71b
6 changed files with 39 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
HISTORY.txt
View File

@ -31,6 +31,7 @@ Genesis Plus GX 1.7.5 (xx/xx/xxxx) (Eke-Eke)
* improved Word-RAM byte access accuracy (verified on schematics) * improved Word-RAM byte access accuracy (verified on schematics)
* improved GFX processing accuracy to halt it while Word RAM is allocated to Main CPU in 2M mode * improved GFX processing accuracy to halt it while Word RAM is allocated to Main CPU in 2M mode
* improved GFX timing accuracy (fixes "Night Striker" crashing after completing a game) * improved GFX timing accuracy (fixes "Night Striker" crashing after completing a game)
* improved Sub-CPU BUSREQ status accuracy
* disabled 68k and Z80 access to PRG-RAM when SUB-CPU is running (fixes "Dungeon Explorer") * disabled 68k and Z80 access to PRG-RAM when SUB-CPU is running (fixes "Dungeon Explorer")
* disabled CD hardware reset on Soft-Reset (verified on real hardware) * disabled CD hardware reset on Soft-Reset (verified on real hardware)
* fixed potential load issues with non-zero backup RAM cart * fixed potential load issues with non-zero backup RAM cart

BIN
builds/genesis_plus_gx_libretro.dll
View File

Binary file not shown.

BIN
builds/genplus_cube.dol
View File

Binary file not shown.
Side by Side Swipe Overlay

Before

Width:  |  Height:  |  Size: 3.8 MiB

After

Width:  |  Height:  |  Size: 3.8 MiB

BIN
builds/genplus_wii.dol
View File

Binary file not shown.
Side by Side Swipe Overlay

Before

Width:  |  Height:  |  Size: 4.0 MiB

After

Width:  |  Height:  |  Size: 4.0 MiB

56
core/mem68k.c
View File

@ -3,7 +3,7 @@
* Main 68k bus handlers * Main 68k bus handlers
* *
* Copyright (C) 1998-2003 Charles Mac Donald (original code) * Copyright (C) 1998-2003 Charles Mac Donald (original code)
* Copyright (C) 2007-2022 Eke-Eke (Genesis Plus GX) * Copyright (C) 2007-2023 Eke-Eke (Genesis Plus GX)
* *
* Redistribution and use of this code or any derivative works are permitted * Redistribution and use of this code or any derivative works are permitted
* provided that the following conditions are met: * provided that the following conditions are met:
@ -696,29 +696,40 @@ void ctrl_io_write_byte(unsigned int address, unsigned int data)
/* RESET bit */ /* RESET bit */
if (data & 0x01) if (data & 0x01)
{ {
/* trigger reset on 0->1 transition */ /* SUB-CPU reset is triggered on /RESET input 0->1 transition */
if (!(scd.regs[0x00].byte.l & 0x01)) if (!(scd.regs[0x00].byte.l & 0x01))
{ {
/* reset SUB-CPU */
s68k_pulse_reset(); s68k_pulse_reset();
} }
/* BUSREQ bit */ /* BUSREQ bit */
if (data & 0x02) if (data & 0x02)
{ {
/* SUB-CPU bus requested */ /* SUB-CPU is halted (/HALT input is asserted) */
s68k_pulse_halt(); s68k_pulse_halt();
} }
else else
{ {
/* SUB-CPU bus released */ /* SUB-CPU is running (/HALT input is released) */
s68k_clear_halt(); s68k_clear_halt();
} }
/* update BUSREQ and RESET bits */
scd.regs[0x00].byte.l = data & 0x03;
} }
else else
{ {
/* SUB-CPU is halted while !RESET is asserted */ /* SUB-CPU is halted (/HALT and /RESET inputs are asserted) */
s68k_pulse_halt(); s68k_pulse_halt();
/* RESET bit is cleared and BUSREQ bit is set to 1 (verified on real hardware) */
scd.regs[0x00].byte.l = 0x02;
}
/* BUSREQ bit remains set to 0 if SUB-CPU is halted while stopped (verified on real hardware) */
if (s68k.stopped & 0x01)
{
scd.regs[0x00].byte.l &= ~0x02;
} }
/* check if SUB-CPU halt status has changed */ /* check if SUB-CPU halt status has changed */
@ -727,8 +738,8 @@ void ctrl_io_write_byte(unsigned int address, unsigned int data)
/* PRG-RAM (128KB bank) is normally mapped to $020000-$03FFFF (resp. $420000-$43FFFF) */ /* PRG-RAM (128KB bank) is normally mapped to $020000-$03FFFF (resp. $420000-$43FFFF) */
unsigned int base = scd.cartridge.boot + 0x02; unsigned int base = scd.cartridge.boot + 0x02;
/* PRG-RAM can only be accessed from MAIN 68K & Z80 when SUB-CPU is halted (Dungeon Explorer USA version) */ /* PRG-RAM can only be accessed from MAIN-CPU & Z80 when BUSREQ bit is set (Dungeon Explorer USA version) */
if ((data & 0x03) != 0x01) if (scd.regs[0x00].byte.l & 0x02)
{ {
m68k.memory_map[base].read8 = m68k.memory_map[base+1].read8 = NULL; m68k.memory_map[base].read8 = m68k.memory_map[base+1].read8 = NULL;
m68k.memory_map[base].read16 = m68k.memory_map[base+1].read16 = NULL; m68k.memory_map[base].read16 = m68k.memory_map[base+1].read16 = NULL;
@ -748,7 +759,6 @@ void ctrl_io_write_byte(unsigned int address, unsigned int data)
} }
} }
scd.regs[0x00].byte.l = data;
return; return;
} }
@ -934,29 +944,40 @@ void ctrl_io_write_word(unsigned int address, unsigned int data)
/* RESET bit */ /* RESET bit */
if (data & 0x01) if (data & 0x01)
{ {
/* trigger reset on 0->1 transition */ /* SUB-CPU reset is triggered on /RESET input 0->1 transition */
if (!(scd.regs[0x00].byte.l & 0x01)) if (!(scd.regs[0x00].byte.l & 0x01))
{ {
/* reset SUB-CPU */
s68k_pulse_reset(); s68k_pulse_reset();
} }
/* BUSREQ bit */ /* BUSREQ bit */
if (data & 0x02) if (data & 0x02)
{ {
/* SUB-CPU bus requested */ /* SUB-CPU is halted (/HALT input is asserted) */
s68k_pulse_halt(); s68k_pulse_halt();
} }
else else
{ {
/* SUB-CPU bus released */ /* SUB-CPU is running (/HALT input is released) */
s68k_clear_halt(); s68k_clear_halt();
} }
/* update BUSREQ and RESET bits */
scd.regs[0x00].byte.l = data & 0x03;
} }
else else
{ {
/* SUB-CPU is halted while !RESET is asserted */ /* SUB-CPU is halted (/HALT and /RESET inputs are asserted) */
s68k_pulse_halt(); s68k_pulse_halt();
/* RESET bit is cleared and BUSREQ bit is set to 1 (verified on real hardware) */
scd.regs[0x00].byte.l = 0x02;
}
/* BUSREQ bit remains set to 0 if SUB-CPU is halted while stopped (verified on real hardware) */
if (s68k.stopped & 0x01)
{
scd.regs[0x00].byte.l &= ~0x02;
} }
/* check if SUB-CPU halt status has changed */ /* check if SUB-CPU halt status has changed */
@ -965,8 +986,8 @@ void ctrl_io_write_word(unsigned int address, unsigned int data)
/* PRG-RAM (128KB bank) is normally mapped to $020000-$03FFFF (resp. $420000-$43FFFF) */ /* PRG-RAM (128KB bank) is normally mapped to $020000-$03FFFF (resp. $420000-$43FFFF) */
unsigned int base = scd.cartridge.boot + 0x02; unsigned int base = scd.cartridge.boot + 0x02;
/* PRG-RAM can only be accessed from MAIN 68K & Z80 when SUB-CPU is halted (Dungeon Explorer USA version) */ /* PRG-RAM can only be accessed from MAIN-CPU & Z80 when BUSREQ bit is set (Dungeon Explorer USA version) */
if ((data & 0x03) != 0x01) if (scd.regs[0x00].byte.l & 0x02)
{ {
m68k.memory_map[base].read8 = m68k.memory_map[base+1].read8 = NULL; m68k.memory_map[base].read8 = m68k.memory_map[base+1].read8 = NULL;
m68k.memory_map[base].read16 = m68k.memory_map[base+1].read16 = NULL; m68k.memory_map[base].read16 = m68k.memory_map[base+1].read16 = NULL;
@ -1002,9 +1023,6 @@ void ctrl_io_write_word(unsigned int address, unsigned int data)
s68k_update_irq((scd.pending & scd.regs[0x32>>1].byte.l) >> 1); s68k_update_irq((scd.pending & scd.regs[0x32>>1].byte.l) >> 1);
} }
} }
/* update LSB only */
scd.regs[0x00].byte.l = data & 0xff;
return; return;
} }

2
core/mem68k.h
View File

@ -3,7 +3,7 @@
* Main 68k bus handlers * Main 68k bus handlers
* *
* Copyright (C) 1998-2003 Charles Mac Donald (original code) * Copyright (C) 1998-2003 Charles Mac Donald (original code)
* Copyright (C) 2007-2022 Eke-Eke (Genesis Plus GX) * Copyright (C) 2007-2023 Eke-Eke (Genesis Plus GX)
* *
* Redistribution and use of this code or any derivative works are permitted * Redistribution and use of this code or any derivative works are permitted
* provided that the following conditions are met: * provided that the following conditions are met: