Merge pull request #10721 from Dentomologist/fix_warnings_on_generic_builder

Fix warnings on generic builder
This commit is contained in:
Admiral H. Curtiss 2022-06-04 21:51:58 +02:00 committed by GitHub
commit 96f9d1000d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 3 deletions

View File

@ -584,7 +584,6 @@ bool DSPAssembler::VerifyParams(const DSPOPCTemplate* opc, param_t* par, size_t
}
}
break;
case P_ACCL:
if ((int)par[i].val < DSP_REG_ACL0 || (int)par[i].val > DSP_REG_ACL1)
{
@ -602,6 +601,8 @@ bool DSPAssembler::VerifyParams(const DSPOPCTemplate* opc, param_t* par, size_t
}
}
break;
default:
break;
}
continue;
}

View File

@ -93,7 +93,7 @@ TEST(FileSystem, PathSplitting)
TEST_F(FileSystemTest, EssentialDirectories)
{
for (const std::string& path :
for (const std::string path :
{"/sys", "/ticket", "/title", "/shared1", "/shared2", "/tmp", "/import", "/meta"})
{
EXPECT_TRUE(m_fs->ReadDirectory(Uid{0}, Gid{0}, path).Succeeded()) << path;
@ -457,7 +457,7 @@ TEST_F(FileSystemTest, CreateFullPath)
ASSERT_EQ(m_fs->CreateFullPath(Uid{0}, Gid{0}, "/tmp/a/b/c/d", 0, modes), ResultCode::Success);
// Parent directories should be created by CreateFullPath.
for (const std::string& path : {"/tmp", "/tmp/a", "/tmp/a/b", "/tmp/a/b/c"})
for (const std::string path : {"/tmp", "/tmp/a", "/tmp/a/b", "/tmp/a/b/c"})
EXPECT_TRUE(m_fs->ReadDirectory(Uid{0}, Gid{0}, path).Succeeded());
// If parent directories already exist, the call should still succeed.