Lioncash
9d8e8652fb
CodeBlock: Get rid of implicit sign-conversion in AllocCodeSpace
...
Size is internally stored as a size_t, so having an int parameter
would cause implicit sign-conversion from a signed value to an
unsigned value to occur.
2017-01-07 19:05:06 -05:00
Matthew Parlane
7847ca41e2
Merge pull request #4607 from leoetlino/execute
...
IOS HLE: Refactor ExecuteCommand
2017-01-08 11:20:49 +13:00
JosJuice
3fdcbbdd92
Automatic translation resources sync with Transifex
2017-01-07 12:03:28 +01:00
Matthew Parlane
82e003ebb6
Merge pull request #4620 from JosJuice/android-byteswap
...
Don't use generic byteswapping on Android
2017-01-07 14:01:33 +13:00
Markus Wick
c380dceb78
Merge pull request #4581 from degasus/blendstate
...
OGL: Move blending logic in VideoCommon.
2017-01-06 16:28:12 +01:00
degasus
f6c7a258ed
BlendState: Use masking as a fastpath for the logic op NO_OP.
2017-01-06 14:01:39 +01:00
degasus
23b0faeba5
OGL: Use VideoCommon blend state for framebuffer configuration.
2017-01-06 14:01:39 +01:00
degasus
3df828463d
VideoCommon: Assembly blending state in a shared state object.
2017-01-06 14:01:36 +01:00
JosJuice
5e2b2f059f
Don't use generic byteswapping on Android
...
This seems to work fine nowadays.
2017-01-06 13:56:53 +01:00
Markus Wick
c33c9532a7
Merge pull request #4594 from lioncash/regcache
...
DSPJitRegCache: Make single argument constructor explicit
2017-01-06 13:01:40 +01:00
Markus Wick
878058ce68
Merge pull request #4613 from lioncash/scrubber
...
DiscScrubber: Minor changes
2017-01-06 13:00:51 +01:00
Markus Wick
82d45435fd
Merge pull request #4616 from lioncash/hle
...
HLE: Align table formatting
2017-01-06 12:57:16 +01:00
Markus Wick
c633eeb383
Merge pull request #4619 from PEmu1/configuration
...
Change "Configure" to "Configuration" in Menu
2017-01-06 12:54:17 +01:00
PEmu1
398d544ebf
Change "Configure" to "Configuration" in Menu
...
Other settings options are nouns rather than verbs so this change makes the configuration option consistent with others. Also makes the menu option label the same as the windows title.
2017-01-05 14:33:24 -08:00
Mat M
e7359f247b
Merge pull request #4595 from aldelaro5/add-debugger-hotkeys
...
Add debugger hotkeys
2017-01-05 14:33:10 -05:00
Mat M
6fe621f203
Merge pull request #4589 from ligfx/cleaninputconfigdiag
...
InputConfigDiag: move function bodies out of header
2017-01-05 14:29:35 -05:00
Mat M
0de4ad334f
Merge pull request #4605 from PEmu1/tas-gamecube-contro
...
Clarify GameCube Controller in TAS Input
2017-01-05 14:28:54 -05:00
Mat M
495580637f
Merge pull request #4606 from BhaaLseN/clang-format-union
...
specify custom brace style to fix unions
2017-01-05 14:27:27 -05:00
Mat M
9da6982ac3
Merge pull request #4608 from RisingFog/input_display_newlines
...
Add missing new lines for OSD
2017-01-05 14:25:24 -05:00
Mat M
189e5f87fb
Merge pull request #4612 from PEmu1/memcard-menu
...
Don't Use Abbreviation for "Memory Card"
2017-01-05 14:22:54 -05:00
Lioncash
a10bb15f17
HLE: Add explicit initializers for OSBreakPoints' stub entry
...
No behavior change, this just makes implicit values explicit.
2017-01-05 14:15:45 -05:00
Lioncash
2941468857
HLE: Align table formatting
2017-01-05 14:13:30 -05:00
PEmu1
6d195f3d65
Don't Use Abbreviation for "Memory Card"
2017-01-05 10:06:46 -08:00
BhaaL
23d99f2f2c
specify custom brace style to fix unions
...
BreakBeforeBraces: Allman apparently includes all styles,
except for AfterUnion (which is false) when using clang-format -dump-config
2017-01-05 12:55:13 +01:00
JosJuice
41101be545
Merge pull request #4611 from lioncash/fileutil
...
IOFile: Minor changes
2017-01-05 09:17:03 +01:00
Lioncash
a93861ab49
DiscScrubber: Don't take SFileInfo instances by value
...
Avoids unnecessary copies.
2017-01-04 20:12:49 -05:00
Lioncash
c52d1e735a
DiscScrubber: Use an unsigned loop index in ParseDisc
...
Prevents an implicit signed to unsigned conversion when assigning a
partition's group number.
2017-01-04 20:03:12 -05:00
Lioncash
6ff21c48cb
DiscScrubber: Correct printf specifiers
2017-01-04 19:56:39 -05:00
Lioncash
b1a2dec78a
DiscScrubber: Convert a #define into a typed constant
2017-01-04 19:53:31 -05:00
Léo Lam
a15be890e1
WII_IPC_HLE: Update the "IOS basics" comment
...
The codebase has changed since it was written, so it needed
a small update.
2017-01-05 01:11:52 +01:00
Léo Lam
00268443ca
WII_IPC_HLE: Replace #defines with constexpr
2017-01-05 01:04:20 +01:00
Léo Lam
9abfa54c9d
IOS HLE: Remove s_es_inuse
...
We don't really have to keep track of device opens/closes manually,
since we can already check that by calling IsOpened() on the device.
This also replaces some loops with for range loops.
2017-01-05 01:04:19 +01:00
Lioncash
045a8400e6
IOFile: Make the move constructor and move assignment operator noexcept
...
Certain parts of the standard library try to determine whether or not a
transfer operation should either be a copy or a move. The prevalent notion
of move constructors/assignment operators is that they should not throw,
they simply move an already existing resource somewhere else.
This is typically done with 'std::move_if_noexcept'. Like the name says,
if a type's move constructor is noexcept, then the functions retrieves an
r-value reference (for move semantics), or an l-value (for copy semantics)
if it is not noexcept.
As IOFile deletes the copy constructor and copy assignment operators,
using IOFile with certain parts of the standard library can fail in
unexcepted ways (especially when used with various container
implementations). This prevents that.
2017-01-04 18:37:48 -05:00
Lioncash
9b8f5bce22
IOFile: Change 'operator void*' into 'explicit operator bool'
...
'operator void*' is basically a pre-C++11-ism that was used, as C++03
only had the notion of implicit type-conversion operators, but not explicit type
conversion operators (allowing implicit conversion of a file handle to
bool can go downhill pretty quickly).
2017-01-04 18:10:21 -05:00
JosJuice
0eaeca9d6d
Merge pull request #3352 from lioncash/scrub
...
DiscScrubber: Turn into a class
2017-01-04 23:57:52 +01:00
Lioncash
c541e1099e
IOFile: Make class variables private
...
Internals shouldn't be directly exposed.
2017-01-04 17:48:46 -05:00
Lioncash
c21dad9e83
IOFile: Get rid of unnecessary unimplemented copy constructor/assignment operator.
...
IOFile already inherits NonCopyable.
2017-01-04 17:47:40 -05:00
Lioncash
5b1aae0cbf
DiscScrubber: Make struct and variable names conformant to the coding style
2017-01-04 17:04:41 -05:00
Lioncash
4a9bc2340b
DiscScrubber: Convert into a class
...
Allows potential multiple scrubbers to run at once. Also gets rid of the
need to explicitly clean up resources.
2017-01-04 16:06:21 -05:00
Markus Wick
389f8297c3
Merge pull request #4577 from degasus/videocommon
...
OGL/Vulkan: Drop destination alpha pass.
2017-01-04 20:05:26 +01:00
degasus
41b0c74e30
VideoCommon: Make dst_alpha state implicit.
2017-01-04 20:02:31 +01:00
degasus
b7d8bd13a6
OGL/Vulkan: Drop dual pass alpha.
2017-01-04 19:59:41 +01:00
JosJuice
f46f779f70
Merge pull request #4609 from lioncash/dspdisasm
...
DSPDisassembler: directly initialize AssemblerSettings struct members
2017-01-04 19:52:52 +01:00
Léo Lam
b65ad538ba
IOS HLE: Refactor ExecuteCommand
...
ExecuteCommand was becoming pretty confusing with unused variables
for some commands, confusing names (device ID != IOS file descriptor),
duplicated checks, not keeping the indentation level low, and having
tons of things into a single function.
This commit gives more correct names to variables, deduplicates the
device checking code, and splits ExecuteCommand so that it's
easier to read.
It's worth noting that some device checks have been forgotten in the
past, which has caused a bug (which was recently fixed in 288e75f6).
2017-01-04 19:33:50 +01:00
Lioncash
2cfc0dc8b6
DSPDisassembler: directly initialize AssemblerSettings struct members
...
Same thing, less code.
2017-01-04 12:53:22 -05:00
Chris Burgener
afdcddc0c5
Add missing new lines for OSD
2017-01-04 10:49:52 -05:00
Markus Wick
9f164d7c33
Merge pull request #4593 from lioncash/enum
...
JitRegCache: Move FlushMode enum into RegCache
2017-01-04 16:21:21 +01:00
PEmu1
2dae72f817
Clarify GameCube Controller in TAS Input
2017-01-03 18:03:17 -08:00
Markus Wick
36ced29a51
Merge pull request #4604 from lioncash/global
...
PatchEngine: Get rid of a global variable
2017-01-04 03:02:55 +01:00
Lioncash
5518c6625b
PatchEngine: Get rid of a global variable
2017-01-03 18:59:33 -05:00