The-Homebrew-Cloud/skyline
2
0
Fork 0
mirror of https://github.com/skyline-emu/skyline.git synced 2024-12-23 17:51:52 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add ScopedStackBlocker to RomFile.populate

Browse Source 
We needed to block stack frame lookups past JNI code as Java doesn't follow the ARMv8 frame pointer ABI which leads to invalid pointer dereferences. Any JNI function that throws or handles exceptions must do this now or it may lead to a `SIGSEGV`.
This commit is contained in:
PixelyIon 2022-04-12 01:34:53 +05:30
parent 68e693d9f4
commit 1878e582ad
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/src/main/cpp/loader_jni.cpp
View File

@ -13,6 +13,8 @@
#include "skyline/jvm.h" #include "skyline/jvm.h"
extern "C" JNIEXPORT jint JNICALL Java_emu_skyline_loader_RomFile_populate(JNIEnv *env, jobject thiz, jint jformat, jint fd, jstring appFilesPathJstring, jint systemLanguage) { extern "C" JNIEXPORT jint JNICALL Java_emu_skyline_loader_RomFile_populate(JNIEnv *env, jobject thiz, jint jformat, jint fd, jstring appFilesPathJstring, jint systemLanguage) {
skyline::signal::ScopedStackBlocker stackBlocker;
skyline::loader::RomFormat format{static_cast<skyline::loader::RomFormat>(jformat)}; skyline::loader::RomFormat format{static_cast<skyline::loader::RomFormat>(jformat)};
skyline::Logger::SetContext(&skyline::Logger::LoaderContext); skyline::Logger::SetContext(&skyline::Logger::LoaderContext);