A wrong fps estimation can have visual artifacts among others. Even an estimation without visual artifacts will not be accurate emulation unless the fps was constant anyway.
But now done properly! Basically, a bunch of improvements were made to the script. The previous attempt at this conversion was quickly followed by a rollback since I realized that the script was overlooking certain things that made most of the packs hit or miss whether they would work. A few things missing were:
- It only tested the values from 1 preset. Now, each shader gets compiled per each preset, like what Cemu would do. It also merges the changes done for each preset into one. This should solve cases where one shader would define things separately or repeatedly from preset to preset.
- All* of the shaders are tested to see if they use the converter used the right values for the locations for Vulkan.
Both of these *should* mean that they should both compile and be linkable in Vulkan, which means that I don't have to test each individual shader to see if they work. I will release the two scripts (one used for converting, one used for checking the right values for the locations) tomorrow so that other people might be able to help, if they want. It's fairly straightforward now at least.
* Organize workaround graphic packs
Pretty hard to organize these correctly, but according to our discord discussion, this was the best layout from a bunch I proposed, together with some suggestions.
* Add V4 converter script and instructions on how to use it
Now everyone BotW is done and all of the bugs have been kinked out using it (hopefully...), here's the release of the converter script in all of it's very badly coded glory. I hope I didn't leave too much debug glory in there...
Also, I hope that I didn't make too many grammatical mistakes in the instructions, but hopefully it's easy enough to follow.
Detected some faulty presets with my script, since logging these kind of issues make sense. Doing these separately since otherwise the big commit will make these changes invisible.
Since it's not possible to update 300+ shaders manually and automation was possible, I thought that I'd take the honor and create a script that's able to automatically convert all of the shaders to be cross-compatible with Vulkan. And change the graphic pack versions to version 4 of course.
Also, the script has some nifty testing code which compiled every shader as OpenGL and Vulkan, but for that see the details that I've written below.
**Here's the script that I've made to do all of this. No manual edits were needed:**
https://gist.github.com/Crementif/8d98a855b95f219d95298fb3db99deae
- Split "Offline Squad" and "more tickets" into 2 separate mods (#389)
- Offline squad now have mission selector presets.
- Fix issue with the "Equipment - Force type" mod not working for ground weapons (#398)
- Fix issue with the "Materials - Drop ratio" mod when 100% preset was selected (#392)
- Fix issue with the "Treasure Quality" mod with regular presets
(#xx) refers to Github issues.
...Also added 'glow' in the file name to be more specific.
Add brightness scaling for Guardians, scale original brightness of others instead of overwriting them.
Hmmmmmmmmmmmmmmmmmm...
Many of these new versions had weird white-lines, missing EU and Japan titles. Also changed the name to 3 and 4 multiplayer titles since the 30FPS cap is also there with 30FPS. Changed the description to be more descriptive. Fixed spelling of warriors orochi.
Added a disclaimer to not go online, probably will scare off most people. I thought about patching the online functionality out of this game with this graphic pack, so that you couldn't go online with it, but you would just save and reload Cemu with online enabled...
