This uses a workaround for Cemu's legacy patching (so the backwards compatibility that Cemu provides for patches.txt file, and now defaults too even if Cemuhook is found) not allowing one to have symbols that refer to a memory address that's outside of the game's own executable memory.
Since 1.0 floats are very common, this float was likely used in other game code as well. Changing it to 3.0 could be bad, so it's better to just change the instruction that loads it and does the arrow loading.
The fix here is to just have a symbol available to load the lower half from, instead of hardcoding it which Cemu's backwards compatible patcher doesn't like and softlocks.
* Pictograph fix
Using only this part of the code the camera returned to work correctly.
On ultrawide resolutions it remains the same before this fix
Video showing the fix:https://streamable.com/ovtvvg
* Update rules.txt
Co-authored-by: M&M <goldtextwitch@outlook.com>
Fixes https://github.com/slashiee/cemu_graphic_packs/issues/437
The aspect ratio mod apparently relied more on a shotgun approach, which caused major issues with Vulkan.
Using @getdls addresses, I found out that 2 of the addresses that were being patched to jump to the code cave were unrelated to the aspect ratio, so I had those removed.
Those random jumps probably didn't cause issues because they would jump to code that would just utilize floating point registers that were in-use and then put the result in the wrong register too. While the picked registers would work with the 3D rendering aspect ratio instruction, it wouldn't fail for the other registers since they weren't specific to those.
Anyway, the proper fix was to just make a second code cave for the aspect ratio, which outputted the culling ratio in the proper register. And also make sure it didn't use in-use registers.
I also reverted some of the shader code changes since they are inconsistent with how we've done them for all the other packs. And made them more compatible with the ultrawide resolutions.
Requested (?) by https://github.com/slashiee/cemu_graphic_packs/issues/436
Also improves the naming of the character swap mod since it can be used in any mode, not just adventure mode. This might've been done because it can cause problems in some missions.
Character Swap would crash the game due to some change in Cemu 1.15.8 apparently (no real clue why although it's probably the hex values being weird). Reported by Revan.
Hyrule Warriors resolution pack has a pretty big blending bug in the menus for a bit too. Upscaling compressed formats never goes well. Reported by MelonSpeedruns.
These workarounds were intended for fixing the issues caused by the old WDDM 23 drivers, which offered better performance than their newer counterparts and was able to boot in game prior to Cemu 1.15.17. Now, since BotW is able to boot in game with the newer drivers with similar or better performance, these 2 can be removed as the issues were fixed in WDDM 24 and newer drivers. Intel even removed the DL link to older drivers like the WDDM 23 and 24 ones.
